Update to latest nvda_dmp#16508
Merged
Merged
Conversation
5 tasks
seanbudd
approved these changes
May 9, 2024
Member
|
please add a change log entry to 2024.3 in changes.md under changes for developers |
seanbudd
reviewed
May 9, 2024
seanbudd
approved these changes
May 10, 2024
CyrilleB79
reviewed
May 14, 2024
|
|
||
| * Component updates: | ||
| * Updated Unicode CLDR to version 45.0. (#16507, @OzancanKaratas) | ||
| * Updated fast_diff_match_patch (used to detect changes in terminals and other dynamic content) to version 2.1.0. (#16508, @codeofdusk) |
Contributor
There was a problem hiding this comment.
Not sure, but this does not seem to be an update but rather standard diff match patch being replaced by fast diff match patch.
@codeofdusk, is it correct? If yes, the change log item should be modified.
Contributor
|
Hi to all,
I would rather want also new formulation in the changelog:
* Improved speed and stability, when the console has been used with
braille displays.
This is particularly visible when there is a new content, and when the
buffer in the console becomes large.
|
Contributor
|
@zstanecic |
Contributor
|
Hi,
I am not using UIA notification, just for the testing purposes.
|
Contributor
Author
|
The change log entry is fine as-is, because:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
nvda_dmp has received updates for better handling of large diffs, unicode characters, etc.
Description of how this pull request fixes the issue:
Updates nvda_dmp (and its backing diff-match-patch implementation) to the latest version.
Testing strategy:
Daily testing by two active terminal users.
Known issues with pull request:
None known
Change log entry:
== Changes ==
Code Review Checklist: