Fix numbered headings for Arabic#16425
Merged
Merged
Conversation
michaelDCurran
approved these changes
Apr 23, 2024
seanbudd
added a commit
that referenced
this pull request
May 20, 2024
Fixup of #16425 Discussed here: groups.io/g/nvda-translations/message/3819 Summary of the issue: In 2023.2, the user guide heading numbering for the Arabic translation switched to using Western Arabic numbering. 2024.1 mistakenly switched this back to Eastern Arabic numbering. In #16425, the headers in the table of contents were fixed for Western Arabic, but not in the body. Description of user facing changes Restore Western Arabic numbering style for headings in the body of the document Description of development approach Updated CSS to reflect Western Arabic numbering style i.e. .1.2.3, .1.2.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Discussed here: https://groups.io/g/nvda-translations/message/3819
Summary of the issue:
In 2023.2, the user guide heading numbering for the Arabic translation switched to using Western Arabic numbering.
2024.1 mistakenly switched this back to Eastern Arabic numbering.
Description of user facing changes
Restore Western Arabic numbering style for headings.
Description of development approach
Updated CSS to reflect Western Arabic numbering style i.e.
.1.2.3,.1.2.4Testing strategy:
Compared:
Known issues with pull request:
None
Code Review Checklist: