Make the incompatibility message more explicit#16359
Conversation
|
Cc @XLTechie, @Adriani90 for opinion or English spelling. Cc @britechguy at the origin of the discussion; does it read better? |
|
The updated phrasing is vastly superior to the original. As you can tell from the NVDA Group topic you cited, started by me, even I didn't exactly get what it was trying to tell me and I will admit that I had no idea that it was machine generated, so I thought the comment had somehow come from the add-on's developer. The revised phrasing should be comprehensible to end-users and coders alike. |
|
Note according to this discussion, the following message needs a clarification:
Do you think that I should also reword this one, e.g. indicating that the user can either update the add-on to a compatible version (if one is available) or re-enable incompatible add-ons at their own risks? Just let me know. |
My revised wording would be as follows:NVDA has determined you are using certain add-ons that are incompatible with this new version of NVDA. If you continue installing, these add-ons will be disabled after it completes. After installation, you may use the "Enable (override incompatibility)" option of the Action menu in the Add-On Store to re-enable these add-ons to see if they may still work, and you do so at your own risk. If any add-on identified as incompatible is critically important to you, we recommend that you postpone updating NVDA until such time as a compatible version is available or create a portable copy of your current NVDA, including copying your existing user configuration, as a fall-back prior to updating.Yes, it's long, but I think it presents the options in a comprehensible way and gives options to prevent "getting stuck without." |
|
Thanks for this improvement, I think we will also have to revisit the disclaimer message in the update installer. But for this one, what about something like this? "This add-on was last tested with 2023.1 while the current NVDA version requires the add-on to be tested with 2024.1 or higher. |
|
Definitely works for me. These notifications are for the end user, and even I can sometimes forget that. They need not include every blessed detail, but should cut to the chase, and this does. Personally, I love it. |
|
@Adriani90 and @britechguy, thanks for your participation. @Adriani90 wrote:
It is not clear to me if this proposal is one or two suggestions? What is it meant to replace? Which dialog, or when performing which task? Thanks. |
|
This was my proposal for the incompatibility message in the add-on storeVon meinem iPhone gesendetAm 04.04.2024 um 16:29 schrieb Cyrille Bougot ***@***.***>:
@Adriani90 and @britechguy, thanks for your participation.
@Adriani90 wrote:
Thanks for this improvement, I think we will also have to revisit the disclaimer message in the update installer.
But for this one, what about something like this?
"This add-on was last tested with 2023.1 while the current NVDA version requires the add-on to be tested with 2024.1 or higher. Therefore this add-on is incompatible with this NVDA version. You can enable this add-on at your own risk by overriding the incompatibility in the add-on store, but it is highly recommended to contact the add-on author requesting to update it accordingly."
It is not clear to me if this proposal is one or two suggestions? What is it meant to replace? Which dialog, or when performing which task? Thanks.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Do you mean an alternative suggestion to what I have already modified in this PR, i.e. the message appearing in the Other details fields when an incompatible add-on is selected in the list? Sorry to ask for confirmation again, but there are also other messages regarding compatibility in the Add-on Store, e.g. when installing or activating an incompatible add-on. |
|
I meant indeed as an alternative to what you proposed in this pr, but we could look also how to streamline the messages so that they are not completely different or at least contain similar information. But I guess this is out of scope for this PR right? Von meinem iPhone gesendetAm 04.04.2024 um 16:53 schrieb Cyrille Bougot ***@***.***>:
This was my proposal for the incompatibility message in the add-on store
Do you mean an alternative suggestion to what I have already modified in this PR, i.e. the message appearing in the Other details fields when an incompatible add-on is selected in the list?
Sorry to ask for confirmation again, but there are also other messages regarding compatibility in the Add-on Store, e.g. when installing or activating an incompatible add-on.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Qchristensen
left a comment
There was a problem hiding this comment.
This change looks good, I'm happy with Sean's latest suggestion ("NVDA requires this add-on to be tested with NVDA {nvdaVersion} or higher. ")
…6839) Follow-up of #16359 Summary of the issue: In #16359, an add-on incompatibility message has been made more explicit. Two other similar message need to be made clearer too. Description of user facing changes Modify the original message adding a missing "NVDA" word Rephrased the two other similar incompatibility messages the same way.
Link to issue number:
Discussion in https://nvda.groups.io/g/nvda/topic/clock_add_on_add_on_store/105313955?p=,,,100,0,0,0::recentpostdate/sticky,,,100,2,0,105313955,previd%3D1712173725527803825,nextid%3D1710680040743854194&previd=1712173725527803825&nextid=1710680040743854194
Summary of the issue:
The current incompatibility message for too old add-ons in the add-on store's details is as follows:
The concept of API is not clear for everyone and it is not explained in NVDA's GUI, nor in the User Guide. Thus, the logic of this sentence explaining why the add-on is not compatible is not easily understandable.
Description of user facing changes
Modify the incompatibility reason for too old add-ons as follows:
Description of development approach
Just changed the corresponding string.
Testing strategy:
Manual check of the string in the GUI.
Known issues with pull request:
None.
Code Review Checklist: