Various fixes in advanced settings panel#16275
Merged
Merged
Conversation
seanbudd
approved these changes
Mar 8, 2024
seanbudd
left a comment
Member
There was a problem hiding this comment.
Thanks for the good catches @CyrilleB79
Adriani90
pushed a commit
to Adriani90/nvda
that referenced
this pull request
Mar 13, 2024
Fix-up of nvaccess#16031 Fix-up of other older PRs. Summary of the issue: Various little issues in advanced settings panel: in advanced settings, option regex for text paragraph navigation feature: restoring default advanced settings do not restore this field a wrong regex syntax in this field do not trigger the error message as expected the code to restore defaults in advanced settings panel is working by chance for some combo boxes, just because the default option is the first one. Description of user facing changes restoring advanced settings will now restore the Regex for Text paragraph navigation option a wrong regex syntax for the Regex for Text paragraph navigation will now trigger an error message Also while at it, fixed: a translator's comment a call to self.Layout that probably needs to be called after all the controls are created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fix-up of #16031
Fix-up of other older PRs.
Summary of the issue:
Various little issues in advanced settings panel:
Description of user facing changes
Also while at it, fixed:
self.Layoutthat probably needs to be called after all the controls are createdDescription of development approach
See code
Testing strategy:
Manual tests:
Known issues with pull request:
None
Code Review Checklist:
Cc @mltony