QuickNav commands for menu, toggle button, progress bar and math by mltony · Pull Request #16247 · nvaccess/nvda

mltony · 2024-03-02T00:59:44Z

Link to issue number:

Closes #16001

Summary of the issue:

Feature request: add more QuickNav commands to jump to more roles.

Description of user facing changes

Added 4 new QuickNav commands not assigned to any keyboard gestures:

menu item
toggle button
progress bar
math formula

Description of development approach

Provided IA2 implementations for all 4 QuickNav commands.
Provided UIA implementation for only progress bar as UIA doesn't seem to support other roles.

Testing strategy:

Tested in the following browsers:

Chrome
Firefox
Edge (UIA version; only progress bars)

Tested on the following pages:

Menu items: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menuitem

toggle buttons:

<button type="button" aria-pressed="true"></button>

Progress bar

<label for="file">Downloading progress:</label>
<progress id="file" value="32" max="100"> 32% </progress>

Math: https://en.wikipedia.org/wiki/Kullback%E2%80%93Leibler_divergence

Known issues with pull request:

Not all roles available in UIA mode.

Code Review Checklist:

Documentation:
- Change log entry
- User Documentation
- Developer / Technical Documentation
- Context sensitive help for GUI changes
Testing:
- Unit tests
- System (end to end) tests
- Manual testing
UX of all users considered:
- Speech
- Braille
- Low Vision
- Different web browsers
- Localization in other languages / culture than English
API is compatible with existing add-ons.
Security precautions taken.

Adriani90 · 2024-03-02T10:17:56Z

Thanks Tony for this PR, this also addresses some old issues already on github.
In general the practice in NVDA is all quick navigation keys of aria atributes are also covered in document formating settings, so the user can not only assign a quick nav key to them, but also turn on and off their announcements in the document formating settings.
Could you please add these atributes to the settings category as checkboxes in the elements grouping?

CyrilleB79 · 2024-03-02T22:32:54Z

I wonder if some roles could be factored.

For example just include toggle button with button navigation would be more useful than creating a specific command to jump to toggle buttons.
Also, maybe menu item could be factored with list item?

Moreover do you have real-life use cases for all these commands? Especially jump to progress bar does not seem to be very useful to me. Toggle button alone neither; but factorized with normal button, it seems more relevant as explained earlier.

At last, I think that the unassigned jump command to math content may be useful for some and does not need to be factorized with anything else.

mltony · 2024-03-02T22:38:30Z

@CyrilleB79,
Yes I do have real life use casess fror all these. They are from internal websites at work, so I can't share them. But yeah, we do have web pages overloaded with various elements, so navigating to progress bars and menus is essential. Toggle buttons are also good to be differentiated from other kinds of buttons.
Also Button already includes toggle button.

Adriani90 · 2024-03-02T23:06:07Z

I agree these commands are really needed, especially in complex web environments such as SAP environments they are very useful.There are web interfaces i.e. with 30 buttons and 40 list items such as EIU in financing, but they have only 5 toggle buttons and some menu items that are important so these need to be reached as efficient as possible.This will definitely increase efficiency to the next level on such web interfaces.Von meinem iPhone gesendetAm 02.03.2024 um 23:38 schrieb mltony ***@***.***>: @CyrilleB79, Yes I do have real life use casess fror all these. They are from internal websites at work, so I can't share them. But yeah, we do have web pages overloaded with various elements, so navigating to progress bars and menus is essential. Toggle buttons are also good to be differentiated from other kinds of buttons. Also Button already includes toggle button. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>

Adriani90 · 2024-03-03T18:01:38Z

Also progress bar quick navigation is really useful especially when checking status of certain activities on such interactive complex web interfaces.

@mltony are you planing to add these as checkboxes to the document formating settings as well? This would be very appreciated.

mltony · 2024-03-03T19:13:51Z

I wasn't planning to. I looked at recent PRs that included quicknav commands for tabs and figures - they didn't add any checkboxes.

Adriani90 · 2024-03-03T19:58:52Z

Ah ok I thought figures did, at least for me I can configure if they should be announced or not.Von meinem iPhone gesendetAm 03.03.2024 um 20:14 schrieb mltony ***@***.***>: I wasn't planning to. I looked at recent PRs that included quicknav commands for tabs and figures - they didn't add any checkboxes. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>

Adriani90 · 2024-03-03T20:10:50Z

But actually yeah after giving it more thoughts I cannot find an use case where an user would turn off these specific announcements. So I think you are right.Von meinem iPhone gesendetAm 03.03.2024 um 20:58 schrieb Adriani Botez ***@***.***>:Ah ok I thought figures did, at least for me I can configure if they should be announced or not.Von meinem iPhone gesendetAm 03.03.2024 um 20:14 schrieb mltony ***@***.***>: I wasn't planning to. I looked at recent PRs that included quicknav commands for tabs and figures - they didn't add any checkboxes. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>

CyrilleB79 · 2024-03-03T20:44:56Z

OK, thanks for illustrating with these real-life use cases that seem more than relevant.

XLTechie · 2024-03-04T01:20:04Z

Menuitems are not list items, and nobody expects to find them when looking through list items, and vice versa. When I'm using a site with many menuitems, I do not want to encounter list items while navigating through them. I welcome this proposal for the menuitems alone, which I must deal with frequently on business and banking sites. I have never had to deal so much with toggle buttons that I cared to navigate to them separately from other buttons, but I can believe that this is just an accident of which sites I use. Same with progress bars, but I can imagine circumstances where I might need that, though rarely. Thanks @mltony!

seanbudd

Thanks @mltony - can you resolve merge conflicts?

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

mltony · 2024-03-06T21:29:12Z

@seanbudd, Resolved merge conflicts.

AppVeyorBot · 2024-03-06T22:00:52Z

PASS: Translation comments check.
PASS: Unit tests.
PASS: Lint check.
FAIL: System tests (tags: installer NVDA). See test results for more information.
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/k4d0c5j7g59897l5/artifacts/output/nvda_snapshot_pr16247-31330,d682370f.exe
CI timing (mins):
INIT 0.0,
INSTALL_START 1.0,
INSTALL_END 0.9,
BUILD_START 0.0,
BUILD_END 31.7,
TESTSETUP_START 0.0,
TESTSETUP_END 0.3,
TEST_START 0.0,
TEST_END 0.9,
FINISH_END 0.2

See test results for failed build of commit d682370fe2

Qchristensen

Docs changes read well, good work

…ccess#16247) Closes nvaccess#16001 Summary of the issue: Feature request: add more QuickNav commands to jump to more roles. Description of user facing changes Added 4 new QuickNav commands not assigned to any keyboard gestures: menu item toggle button progress bar math formula Description of development approach Provided IA2 implementations for all 4 QuickNav commands. Provided UIA implementation for only progress bar as UIA doesn't seem to support other roles.

QuickNav commands for menu, toggle button, progress bar and math

8aee1e2

mltony marked this pull request as ready for review March 2, 2024 03:48

mltony requested review from a team as code owners March 2, 2024 03:48

mltony requested review from Qchristensen and gerald-hartig March 2, 2024 03:48

seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Mar 5, 2024

seanbudd approved these changes Mar 6, 2024

View reviewed changes

Comment thread source/UIAHandler/browseMode.py Outdated

Comment thread user_docs/en/changes.t2t Outdated

mltony and others added 3 commits March 6, 2024 13:15

Update source/UIAHandler/browseMode.py

f4890d1

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

Update user_docs/en/changes.t2t

9ce3607

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

Merge branch 'master' into roles

5f595fa

seanbudd approved these changes Mar 7, 2024

View reviewed changes

Qchristensen approved these changes Mar 7, 2024

View reviewed changes

seanbudd merged commit 01df0d4 into nvaccess:master Mar 7, 2024

nvaccessAuto added this to the 2024.2 milestone Mar 7, 2024

Adriani90 mentioned this pull request Mar 31, 2024

Single Letter Navigation to MathML #16350

Closed

Adriani90 mentioned this pull request Apr 24, 2024

Menu and menu item quick navigation keys #7695

Closed

Uh oh!

Conversation

mltony commented Mar 2, 2024

Link to issue number:

Summary of the issue:

Description of user facing changes

Description of development approach

Testing strategy:

Known issues with pull request:

Code Review Checklist:

Uh oh!

Adriani90 commented Mar 2, 2024

Uh oh!

CyrilleB79 commented Mar 2, 2024

Uh oh!

mltony commented Mar 2, 2024

Uh oh!

Adriani90 commented Mar 2, 2024 via email

Uh oh!

Adriani90 commented Mar 3, 2024

Uh oh!

mltony commented Mar 3, 2024

Uh oh!

Adriani90 commented Mar 3, 2024 via email

Uh oh!

Adriani90 commented Mar 3, 2024 via email

Uh oh!

CyrilleB79 commented Mar 3, 2024

Uh oh!

XLTechie commented Mar 4, 2024 via email

Uh oh!

seanbudd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mltony commented Mar 6, 2024

Uh oh!

AppVeyorBot commented Mar 6, 2024

Uh oh!

Qchristensen left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants