Skip to content

Vertical QuickNav#16236

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
mltony:vertical
Mar 6, 2024
Merged

Vertical QuickNav#16236
seanbudd merged 1 commit into
nvaccess:masterfrom
mltony:vertical

Conversation

@mltony

@mltony mltony commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #15999

Summary of the issue:

Feature request: QuickNav command for Vertical navigation

Description of user facing changes

Added new unassigned QuickNav command that jumps to previous/next vertically aligned paragraph.

Description of development approach

Making use of _iterSimilarParagraph function and passing a lambda that extracts x coordinate of a paragraph.

Testing strategy:

  • Tested in Chrome; Firefox
  • Tested in MSWord

Known issues with pull request:

N/A

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@mltony mltony marked this pull request as ready for review February 29, 2024 04:17
@mltony mltony requested review from a team as code owners February 29, 2024 04:17
@amirsol81

Copy link
Copy Markdown

@mltony Thanks for incorporating this into the project! Just a question: do you have any plans to also incorporate your awesome bookmarking feature from BrowserNav into NVDA? This is a killer and powerful BrowserNav facility.

@mltony

mltony commented Feb 29, 2024

Copy link
Copy Markdown
Contributor Author

@amirsol81 , not at this time. Even if I aim at including only one type of bookmarks, I estimate it'll take me probably at least 2 months to do it - I don't have this much time now. And also this would be subject to NVAccess approval. I plan to maintain BrowserNav for the time being - will soon update it to be compatible with NVDA v2024. But thanks for showing your interest!

@amirsol81

Copy link
Copy Markdown

Thanks @mltony for offering extremely powerful add-ons like BrowserNav. It makes life much easier on the web and its bookmarking facility is a huge boon to NVDA users.

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Mar 5, 2024

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mltony !

@seanbudd seanbudd merged commit 96d59ec into nvaccess:master Mar 6, 2024
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Mar 6, 2024
Adriani90 pushed a commit to Adriani90/nvda that referenced this pull request Mar 13, 2024
Fixes nvaccess#15999

Summary of the issue:
Feature request: QuickNav command for Vertical navigation

Description of user facing changes
Added new unassigned QuickNav command that jumps to previous/next vertically aligned paragraph.

Description of development approach
Making use of _iterSimilarParagraph function and passing a lambda that extracts x coordinate of a paragraph.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: add QuickNav command for Vertical navigation in browse mode

4 participants