Support HTML Figures in Chromium by SaschaCowley · Pull Request #16206 · nvaccess/nvda

SaschaCowley · 2024-02-21T06:00:58Z

Link to issue number:

Summary of the issue:

Figures are currently not properly announced by NVDA in browse or focus modes in Chromium.

Description of user facing changes

Figures are now reported in Chrome.

Description of development approach

Since Chromium does not report a role of figure on <figure> elements unless the role has been added, add tests for a tag of figure on Chrome objects. Change figure searchable attributes to include the figure tag, since this is necessary to allow navigation by HTML figures in Chrome.

Testing strategy:

Manual tests with a test webpage.

Known issues with pull request:

Quick navigation by figure will land on <figure> elements whose role has been set to something other than figure.

Code Review Checklist:

Documentation:
- Change log entry
- User Documentation
- Developer / Technical Documentation
- Context sensitive help for GUI changes
Testing:
- Unit tests
- System (end to end) tests
- Manual testing
UX of all users considered:
- Speech
- Braille
- Low Vision
- Different web browsers
- Localization in other languages / culture than English
API is compatible with existing add-ons.
Security precautions taken.

AppVeyorBot · 2024-02-21T06:37:23Z

PASS: Translation comments check.
PASS: Unit tests.
FAIL: Lint check. See test results for more information.
PASS: System tests (tags: installer NVDA).
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/t7paj6pear6wp87o/artifacts/output/nvda_snapshot_pr16206-31128,a72df41a.exe
CI timing (mins):
INIT 0.0,
INSTALL_START 1.1,
INSTALL_END 1.0,
BUILD_START 0.0,
BUILD_END 30.0,
TESTSETUP_START 0.0,
TESTSETUP_END 0.4,
TEST_START 0.0,
TEST_END 2.4,
FINISH_END 0.2

See test results for failed build of commit a72df41a91

AppVeyorBot · 2024-03-06T01:10:53Z

PASS: Translation comments check.
PASS: Unit tests.
FAIL: Lint check. See test results for more information.
PASS: System tests (tags: installer NVDA).
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/2891l3c5y9dna48b/artifacts/output/nvda_snapshot_pr16206-31298,ae04cade.exe
CI timing (mins):
INIT 0.0,
INSTALL_START 1.1,
INSTALL_END 1.0,
BUILD_START 0.0,
BUILD_END 28.9,
TESTSETUP_START 0.0,
TESTSETUP_END 0.4,
TEST_START 0.0,
TEST_END 2.3,
FINISH_END 0.2

See test results for failed build of commit ae04cadee1

…e custom roles defined

AppVeyorBot · 2024-03-06T05:11:33Z

PASS: Translation comments check.
PASS: Unit tests.
FAIL: Lint check. See test results for more information.
FAIL: System tests (tags: installer NVDA). See test results for more information.
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/2o4l9ha831je9lh1/artifacts/output/nvda_snapshot_pr16206-31312,1fb40c1c.exe
CI timing (mins):
INIT 0.0,
INSTALL_START 1.0,
INSTALL_END 0.9,
BUILD_START 0.0,
BUILD_END 29.1,
TESTSETUP_START 0.0,
TESTSETUP_END 0.2,
TEST_START 0.0,
TEST_END 0.7,
FINISH_END 0.2

See test results for failed build of commit 1fb40c1c47

AppVeyorBot · 2024-03-06T06:57:32Z

PASS: Translation comments check.
PASS: Unit tests.
PASS: Lint check.
FAIL: System tests (tags: installer NVDA). See test results for more information.
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/412b1h1ffxra7m34/artifacts/output/nvda_snapshot_pr16206-31322,ee6178bb.exe
CI timing (mins):
INIT 0.0,
INSTALL_START 1.1,
INSTALL_END 0.9,
BUILD_START 0.0,
BUILD_END 29.5,
TESTSETUP_START 0.0,
TESTSETUP_END 0.3,
TEST_START 0.0,
TEST_END 0.8,
FINISH_END 0.2

See test results for failed build of commit ee6178bbfd

seanbudd

Thanks @SaschaCowley. As the testing field is unticked, can you confirm you've tested this?

SaschaCowley · 2024-03-13T02:58:52Z

Thanks @SaschaCowley. As the testing field is unticked, can you confirm you've tested this?

This has been manually tested. The initial PR comment has been updated to reflect this.

Fixes nvaccess#16137 Summary of the issue: Figures are currently not properly announced by NVDA in browse or focus modes in Chromium. Description of user facing changes Figures are now reported in Chrome. Description of development approach: Since Chromium does not report a role of figure on <figure> elements unless the role has been added, add tests for a tag of figure on Chrome objects. Change figure searchable attributes to include the figure tag, since this is necessary to allow navigation by HTML figures in Chrome. Known issues: Quick navigation by figure will land on <figure> elements whose role has been set to something other than figure.

Sascha Cowley added 3 commits February 21, 2024 12:56

Figure elements reported in browse mode in Chromium

268e69f

Figures in Chromium now working with object nav

07f95af

Merge branch 'master' into chromium_figures

7aa9849

SaschaCowley requested a review from michaelDCurran February 21, 2024 06:02

seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Mar 4, 2024

Merge branch 'master' into chromium_figures

c302339

Sascha Cowley added 4 commits March 6, 2024 12:15

Moved fixes to be Chromium-specific, and fixed case where figures hav…

76e51ee

…e custom roles defined

Undid some no-longer needed changes

6723a1e

Implemented navigation by HTML figure in chromium

bc529fc

Fixed formatting issues

c319a50

SaschaCowley marked this pull request as ready for review March 6, 2024 07:03

SaschaCowley requested a review from a team as a code owner March 6, 2024 07:03

seanbudd approved these changes Mar 7, 2024

View reviewed changes

Apply suggestions from code review

1fb1000

SaschaCowley merged commit 7f6734a into nvaccess:master Mar 13, 2024

nvaccessAuto added this to the 2024.2 milestone Mar 13, 2024

SaschaCowley deleted the chromium_figures branch August 22, 2024 05:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support HTML Figures in Chromium#16206

Support HTML Figures in Chromium#16206
SaschaCowley merged 9 commits into
nvaccess:masterfrom
SaschaCowley:chromium_figures

SaschaCowley commented Feb 21, 2024 •

edited

Loading

Uh oh!

AppVeyorBot commented Feb 21, 2024

Uh oh!

AppVeyorBot commented Mar 6, 2024

Uh oh!

AppVeyorBot commented Mar 6, 2024

Uh oh!

AppVeyorBot commented Mar 6, 2024

Uh oh!

seanbudd left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SaschaCowley commented Mar 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

SaschaCowley commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link to issue number:

Summary of the issue:

Description of user facing changes

Description of development approach

Testing strategy:

Known issues with pull request:

Code Review Checklist:

Uh oh!

AppVeyorBot commented Feb 21, 2024

Uh oh!

AppVeyorBot commented Mar 6, 2024

Uh oh!

AppVeyorBot commented Mar 6, 2024

Uh oh!

AppVeyorBot commented Mar 6, 2024

Uh oh!

seanbudd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SaschaCowley commented Mar 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SaschaCowley commented Feb 21, 2024 •

edited

Loading