Skip to content

[Hims] fix incorrectly assigned combination keys in braillesense device#16118

Merged
seanbudd merged 7 commits into
nvaccess:masterfrom
EdKweon:modify_braillsense_key
Feb 2, 2024
Merged

[Hims] fix incorrectly assigned combination keys in braillesense device#16118
seanbudd merged 7 commits into
nvaccess:masterfrom
EdKweon:modify_braillsense_key

Conversation

@EdKweon

@EdKweon EdKweon commented Feb 1, 2024 •
edited by seanbudd
Loading

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #15306

Summary of the issue:

With a Hims BrailleSense 6, in terminal mode, four braille combinations cannot be performed on the braille keyboard.

Description of user facing changes

Some characters in french can type alt+arrow combination keys in braillesense.

Description of development approach

alt+arrow combination keys in hims driver which were assigned to Braillesense device was changed.

Testing strategy:

unit test. system test. lint test. and perform test alt+arrow keys with BrailleSense6.

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@EdKweon EdKweon requested review from a team as code owners February 1, 2024 02:21
@EdKweon EdKweon changed the title [Hims] fix incorrectly assigned combination keys in braillesense [Hims] fix incorrectly assigned combination keys in braillesense device Feb 1, 2024
seanbudd
seanbudd reviewed Feb 1, 2024
View reviewed changes
Comment thread user_docs/en/changes.t2t Outdated
Comment thread user_docs/en/changes.t2t Outdated
Comment thread user_docs/en/userGuide.t2t Outdated
@seanbudd

seanbudd commented Feb 1, 2024

Copy link
Copy Markdown
Member

I've moved the relevant issue number to the right section in the PR template

@seanbudd seanbudd marked this pull request as draft February 1, 2024 03:29
EdKweon and others added 4 commits February 1, 2024 13:09
@EdKweon @seanbudd
Update user_docs/en/changes.t2t
f4f560f 
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
@EdKweon @seanbudd
Update user_docs/en/changes.t2t
13d6f5b 
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
@EdKweon @seanbudd
Update user_docs/en/userGuide.t2t
1416648 
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
@EdKweon
update userGuide and changes.t2t
b80c46b
@EdKweon

EdKweon commented Feb 1, 2024

Copy link
Copy Markdown
Contributor Author

@seanbudd
Thanks for review. I updated log and userGuide.

@AppVeyorBot

AppVeyorBot commented Feb 1, 2024

Copy link
Copy Markdown

See test results for failed build of commit 81c6e280b2

CyrilleB79
CyrilleB79 reviewed Feb 1, 2024
View reviewed changes
Comment thread user_docs/en/changes.t2t Outdated
@EdKweon @CyrilleB79
Update user_docs/en/changes.t2t
7582481 
Co-authored-by: Cyrille Bougot <cyrille.bougot2@laposte.net>
@EdKweon

EdKweon commented Feb 1, 2024

Copy link
Copy Markdown
Contributor Author

@CyrilleB79
Thank you for feedback I applied with your review.

@AppVeyorBot

AppVeyorBot commented Feb 1, 2024

Copy link
Copy Markdown

See test results for failed build of commit 7b03f86355

@CyrilleB79

CyrilleB79 commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

@EdKweon, this PR is in draft state.

If your work is done and you want it to be reviewed/merged by NV Access, you should make it ready again by clicking the "Ready for review" button.

@EdKweon EdKweon marked this pull request as ready for review February 1, 2024 11:45
@EdKweon

EdKweon commented Feb 1, 2024

Copy link
Copy Markdown
Contributor Author

@CyrilleB79
Okay. I made it ready. Thanks.

seanbudd
seanbudd reviewed Feb 1, 2024
View reviewed changes
Comment thread user_docs/en/changes.t2t
Comment thread user_docs/en/changes.t2t Outdated
Comment thread user_docs/en/userGuide.t2t Outdated
Comment thread user_docs/en/userGuide.t2t Outdated
Comment thread user_docs/en/userGuide.t2t Outdated
@seanbudd seanbudd merged commit 6d97c5a into nvaccess:master Feb 2, 2024
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Feb 2, 2024
@EdKweon EdKweon deleted the modify_braillsense_key branch February 2, 2024 04:09
Nael-Sayegh pushed a commit to Nael-Sayegh/nvda that referenced this pull request Feb 15, 2024
@EdKweon @Nael-Sayegh
[Hims] fix incorrectly assigned combination keys in braillesense devi…
cecc1b6 
…ce (nvaccess#16118)

Fixes nvaccess#15306

Summary of the issue:
With a Hims BrailleSense 6, in terminal mode, four braille combinations cannot be performed on the braille keyboard.

Description of user facing changes
Some characters in french can type alt+arrow combination keys in braillesense.

Description of development approach
alt+arrow combination keys in hims driver which were assigned to Braillesense device was changed.
SaschaCowley pushed a commit to SaschaCowley/nvda that referenced this pull request Feb 27, 2024
@EdKweon
[Hims] fix incorrectly assigned combination keys in braillesense devi…
01aca19 
…ce (nvaccess#16118)

Fixes nvaccess#15306

Summary of the issue:
With a Hims BrailleSense 6, in terminal mode, four braille combinations cannot be performed on the braille keyboard.

Description of user facing changes
Some characters in french can type alt+arrow combination keys in braillesense.

Description of development approach
alt+arrow combination keys in hims driver which were assigned to Braillesense device was changed.
Adriani90 pushed a commit to Adriani90/nvda that referenced this pull request Mar 13, 2024
@EdKweon @Adriani90
[Hims] fix incorrectly assigned combination keys in braillesense devi…
e0bde51 
…ce (nvaccess#16118)

Fixes nvaccess#15306

Summary of the issue:
With a Hims BrailleSense 6, in terminal mode, four braille combinations cannot be performed on the braille keyboard.

Description of user facing changes
Some characters in french can type alt+arrow combination keys in braillesense.

Description of development approach
alt+arrow combination keys in hims driver which were assigned to Braillesense device was changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

@Qchristensen Qchristensen Awaiting requested review from Qchristensen Qchristensen was automatically assigned from nvaccess/userdocs

@SaschaCowley SaschaCowley Awaiting requested review from SaschaCowley SaschaCowley is a code owner automatically assigned from nvaccess/developers

+1 more reviewer

@CyrilleB79 CyrilleB79 CyrilleB79 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2024.2

Development

Successfully merging this pull request may close these issues.

Unable to write some characters with Braille Sense in french

5 participants

@EdKweon @seanbudd @AppVeyorBot @CyrilleB79 @nvaccessAuto