Conversation
|
It is recommended to use the order of |
|
I also agree with @wmhn1872265132 that it might be better to replace the left and right column positions. |
Is this implication not an issue with these reversed? Wouldn't you get the impressions that "Options" is the value of "Default" rather than the headers. |
|
I don't think so, because the default is more like one of the options, but there is rarely an option called an option |
|
If you consider a linear reading order, that is, users do not use table navigation to read, then @wmhn1872265132's concerns should be valid. Do we need to think about it, for similar options, do we really need to format it into a table? What are the advantages of using tables? Including the previous list style also seems to have caused some misunderstandings. Before using the list style, did some users report that this was not stated clearly enough. |
|
I understand and share the concern of @cary-rowen and @wmhn1872265132 regarding reading order, with "Options" coming before "Default" when reading with Though, it's more logical to have first the information of the available options and then the default one. I would also add that using columns is not very comfortable since it forces the user to use table navigation to read this 2x2 table. Instead, using rows to store the informations, the user could use either table navigation or just So my recommendation would be to use a table with the information in rows if possible, i.e.:
And, nice to have if possible, with the first column set as rows headers. If horizontal layout is not technically possible, just use list instead:
|
|
Native markdown only supports one type of table: the first row is always column headers, there are no other headers. We can try out an extended python markdown plugin like this one: |
|
This extension doesn't seem to be maintained well. Markdown table: | . {.hideHeaderRow} | . |
|---|---|
| Options | Enabled, Disabled |
| Default | Disabled |CSS thead:has(tr > th.hideHeaderRow) {
display: none;
}HTML output: Rendered HTML output (note no styling)
NVDA Output - note row numbers are wrong |
ff57760 to
f994910
Compare
| # Allows TOC with [TOC]" | ||
| "markdown.extensions.toc", | ||
| # Allows setting attributes with {@id=foo} | ||
| "markdown.extensions.legacy_attrs", |
There was a problem hiding this comment.
this has been removed as extra contains abetter method of setting attributes, and this method with @ conflicts with mdx_gh_links for github username links.
|
What will be the syntax? I am a bit concerned that the translators will have to copy/paste table headers row in the md file, making a md file less easy to read. Or won't this header string appear at all if the documentation is split in CrowdIn? How do these tables behave when the .md file is provided and split for translation? Alternatively, I wonder if the list is not just simpler. Have you considered replacing the table by a list as suggested in #16083 (comment)? Also, @seanbudd, you wrote:
Fully agree with you. The table in my example was meant to illustrate the result I want to achieve in the HTML User Guide; the way these tables were produced are not to be considered in this example. |
|
the syntax is:
```
| . {.hideHeaderRow} |.|
|---|---|
|Options |Default (Never), Never, Only when tethered automatically, Always|
|Default |Never|
```
I believe that translations will be broken up by line. thus yes,
translators will see that first line.
Message ID: ***@***.***>
|
+1 to this. |
Fixes nvaccess#16063 Summary of the issue: nvaccess#15950 converted definition lists to tables, however the conversion could have been done better. Both lines of the table start with header syntax || whereas it should only be the first header. Tables were previously converted from definition lists to look like this Default Enabled Options Default (Enabled), Enabled, Disabled Options should be listed before default logically. The first column should be headers, not the first row. Unfortunately there is no good support for column headers in markdown in our markdown parsing stack. As such, this can be improved by just having no headers. Description of user facing changes Change all option definition tables to be formatted as follows. The header row is hidden in CSS Options Default (Enabled), Enabled, Disabled Default Enabled Description of development approach The following regex was used: find: \|\|(.*)\|(.*)\|\n\|\|(.*)\|(.*)\| replace: || . {.hideHeaderRow} | . |\n|$3|$4|\n|$1|$2| Testing strategy:
Link to issue number:
Fixes #16063
Summary of the issue:
#15950 converted definition lists to tables, however the conversion could have been done better.
Both lines of the table start with header syntax
||whereas it should only be the first header.Tables were previously converted from definition lists to look like this
Options should be listed before default logically.
The first column should be headers, not the first row.
Unfortunately there is no good support for column headers in markdown in our markdown parsing stack.
As such, this can be improved by just having no headers.
Description of user facing changes
Change all option definition tables to be formatted as follows.
The header row is hidden in CSS
Description of development approach
The following regex was used:
\|\|(.*)\|(.*)\|\n\|\|(.*)\|(.*)\||| . {.hideHeaderRow} | . |\n|$3|$4|\n|$1|$2|Testing strategy:
Confirmed by building user docs and checking output
Known issues with pull request:
None
Code Review Checklist: