No longer store strong references to parent object in guiHelper.BoxSizerHelper to decrease likelihood of circular references in NVDA's GUI#16079
Merged
Conversation
…zerHelper to decrease likelihood of circular references in NVDA's GUI
Nael-Sayegh
pushed a commit
to Nael-Sayegh/nvda
that referenced
this pull request
Feb 15, 2024
…zerHelper to decrease likelihood of circular references in NVDA's GUI (nvaccess#16079) Related to nvaccess#16019 Summary of the issue: BoxSizerHelper class stores a strong reference to its parent. When it is mistakenly assigned to a member of its parent a circular reference is created making it impossible for Python's garbage collector to destroy the dialog when it goes out of scope. Description of user facing changes Should not be noticeable. Description of development approach BoxSizerHelper now stores a weak reference to its parent.
SaschaCowley
pushed a commit
to SaschaCowley/nvda
that referenced
this pull request
Feb 27, 2024
…zerHelper to decrease likelihood of circular references in NVDA's GUI (nvaccess#16079) Related to nvaccess#16019 Summary of the issue: BoxSizerHelper class stores a strong reference to its parent. When it is mistakenly assigned to a member of its parent a circular reference is created making it impossible for Python's garbage collector to destroy the dialog when it goes out of scope. Description of user facing changes Should not be noticeable. Description of development approach BoxSizerHelper now stores a weak reference to its parent.
Adriani90
pushed a commit
to Adriani90/nvda
that referenced
this pull request
Mar 13, 2024
…zerHelper to decrease likelihood of circular references in NVDA's GUI (nvaccess#16079) Related to nvaccess#16019 Summary of the issue: BoxSizerHelper class stores a strong reference to its parent. When it is mistakenly assigned to a member of its parent a circular reference is created making it impossible for Python's garbage collector to destroy the dialog when it goes out of scope. Description of user facing changes Should not be noticeable. Description of development approach BoxSizerHelper now stores a weak reference to its parent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Related to #16019
Summary of the issue:
BoxSizerHelperclass stores a strong reference to its parent. When it is mistakenly assigned to a member of its parent a circular reference is created making it impossible for Python's garbage collector to destroy the dialog when it goes out of scope.Description of user facing changes
Should not be noticeable.
Description of development approach
BoxSizerHelpernow stores a weak reference to its parent.Testing strategy:
Temporarily introduced a circular reference between the Add-on Store dialog and one of its sizer helpers - ensured the dialog can be garbage collected when closed.
Known issues with pull request:
None known.
Code Review Checklist: