Adding the minimum version and the latest tested version of NVDA for add-on#16053
Merged
seanbudd merged 11 commits intoJan 23, 2024
Merged
Conversation
CyrilleB79
reviewed
Jan 16, 2024
CyrilleB79
reviewed
Jan 17, 2024
CyrilleB79
left a comment
Contributor
There was a problem hiding this comment.
A rephrasing of the change log.
And also, could you change the title of this PR for clarity, replacing "extension" by "add-on"? "add-on" is the word used in NVDA's English version.
ac4151b to
4737c89
Compare
Contributor
Author
|
@CyrilleB79 Thank you for your advice. I have made the changes, I think it is correct now. |
seanbudd
reviewed
Jan 19, 2024
Contributor
Author
|
@seanbudd I have moved the description in "changes" section and add section add-on store in "changes". |
seanbudd
reviewed
Jan 22, 2024
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
CyrilleB79
reviewed
Jan 22, 2024
Co-authored-by: Cyrille Bougot <cyrille.bougot2@laposte.net>
seanbudd
requested changes
Jan 23, 2024
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Nael-Sayegh
added a commit
to Nael-Sayegh/nvda
that referenced
this pull request
Feb 15, 2024
…add-on (nvaccess#16053) closes nvaccess#15776 Summary of the issue: Having the ability to see the minimum version and the latest tested version of NVDA for an extension in the addonStore. Description of user facing changes In the addonStore, the user will be able to see the minimum version and the latest tested version of NVDA in the details of an extension. Description of development approach Added in the source file\gui\addonStoreGui\controls\details.py in the refresh method, I added compatibility information under the installed version of the module.
SaschaCowley
pushed a commit
to SaschaCowley/nvda
that referenced
this pull request
Feb 27, 2024
…add-on (nvaccess#16053) closes nvaccess#15776 Summary of the issue: Having the ability to see the minimum version and the latest tested version of NVDA for an extension in the addonStore. Description of user facing changes In the addonStore, the user will be able to see the minimum version and the latest tested version of NVDA in the details of an extension. Description of development approach Added in the source file\gui\addonStoreGui\controls\details.py in the refresh method, I added compatibility information under the installed version of the module.
Adriani90
pushed a commit
to Adriani90/nvda
that referenced
this pull request
Mar 13, 2024
…add-on (nvaccess#16053) closes nvaccess#15776 Summary of the issue: Having the ability to see the minimum version and the latest tested version of NVDA for an extension in the addonStore. Description of user facing changes In the addonStore, the user will be able to see the minimum version and the latest tested version of NVDA in the details of an extension. Description of development approach Added in the source file\gui\addonStoreGui\controls\details.py in the refresh method, I added compatibility information under the installed version of the module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
closes #15776
Summary of the issue:
Having the ability to see the minimum version and the latest tested version of NVDA for an extension in the addonStore.
Description of user facing changes
In the addonStore, the user will be able to see the minimum version and the latest tested version of NVDA in the details of an extension.
Description of development approach
Added in the source file\gui\addonStoreGui\controls\details.py in the refresh method, I added compatibility information under the installed version of the module.
Testing strategy:
Go to the addonStore, then select an installed extension, go to the "Other Information" editing area and read the section to see the minimum version and latest tested version.
Known issues with pull request:
Code Review Checklist: