Fix-up of #15864: pluralize battery time reporting string#16011
Merged
Conversation
seanbudd
approved these changes
Jan 7, 2024
Member
|
is this ready for review / to be merged? |
Contributor
Author
|
Yes, ready on my side. |
Adriani90
pushed a commit
to Adriani90/nvda
that referenced
this pull request
Mar 13, 2024
…access#16011) Fix-up of nvaccess#15864. Reported in this thread of the translators mailing list. Summary of the issue: When pluralizing a lot of string in nvaccess#15864, the one dedicated to battery time reporting was forgotten. Description of user facing changes Battery time estimation will be reported with correct plural forms. Description of development approach Split up the string in subparts and use ngettext for hours and for minutes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: PR opened against beta since translation freeze has not yet happened and since translators are currently dealing with a lot of pluralization of strings during 2024.1 dev cycle.
Link to issue number:
Fix-up of #15864.
Reported in this thread of the translators mailing list.
Summary of the issue:
When pluralizing a lot of string in #15864, the one dedicated to battery time reporting was forgotten.
Description of user facing changes
Battery time estimation will be reported with correct plural forms.
Description of development approach
Split up the string in subparts and use
ngettextfor hours and for minutes.Testing strategy:
Manual test of various hour/minute combinations, forcing
systemPowerStatus.BatteryLifeTimein the code.Known issues with pull request:
None
Code Review Checklist: