Skip to content

fix document typos#15972

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
hwf1324:fix-document-typos
Dec 27, 2023
Merged

fix document typos#15972
seanbudd merged 1 commit into
nvaccess:masterfrom
hwf1324:fix-document-typos

Conversation

@hwf1324

@hwf1324 hwf1324 commented Dec 27, 2023

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

Fix one document typos, and one omission.

Description of user facing changes

Description of development approach

Testing strategy:

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@hwf1324 hwf1324 requested a review from a team as a code owner December 27, 2023 12:07
@hwf1324 hwf1324 requested a review from seanbudd December 27, 2023 12:08
* On the Individual components tab, ensure the following items are selected:
* Windows 11 SDK (10.0.22621.0)
* MSVC v143 - VS 2022 C++ ARM64 build tools
* MSVC v143 - VS 2022 C++ ARM64/ARM64EC build tools

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelDCurran - is this true?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it looks like ARM64 and ARM64EC build tools are now bundled together (at least according to the installer UI).
So I think this is a correct change.
Though oddly in the .vsconfig file they are still always split into two separate components when exporting.

@seanbudd seanbudd merged commit d573d13 into nvaccess:master Dec 27, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Dec 27, 2023
@hwf1324 hwf1324 deleted the fix-document-typos branch December 27, 2023 23:47
Nael-Sayegh pushed a commit to Nael-Sayegh/nvda that referenced this pull request Feb 15, 2024
SaschaCowley pushed a commit to SaschaCowley/nvda that referenced this pull request Feb 27, 2024
Adriani90 pushed a commit to Adriani90/nvda that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants