Fix logic error making it impossible to uninstall multiple add-ons#15966
Merged
Conversation
Contributor
|
Thanks @lukaszgo1 for fixing this error introduced by my PR. I am quite sure to have tested this scenario, but probably not re-tested after doing some changes while reviewing the PR. |
Adriani90
pushed a commit
to Adriani90/nvda
that referenced
this pull request
Mar 13, 2024
…vaccess#15966) Summary of the issue: When trying to uninstall multiple add-ons nothing was happening, and according to the log none of the selected add-ons was relevant for remove action. Description of user facing changes It is now possible to uninstall multiple add-ons in the Add-ons Store. Description of development approach The condition which was checking if the given add-on can be removed is inverted, so that the removal is possible when add-on can indeed be removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should go into beta, as it fixes a bug introduced in 2024.1 development cycle. For the same reason I do not include a change log entry,as it is unnecessary. cc @CyrilleB79
Link to issue number:
None
Summary of the issue:
When trying to uninstall multiple add-ons nothing was happening, and according to the log none of the selected add-ons was relevant for remove action.
Description of user facing changes
It is now possible to uninstall multiple add-ons in the Add-ons Store.
Description of development approach
The condition which was checking if the given add-on can be removed is inverted, so that the removal is possible when add-on can indeed be removed.
Testing strategy:
Selected two add-ons in the store, executed 'remove' from the context menu, made sure the removal process works.
Known issues with pull request:
None known
Code Review Checklist: