Ensure the mouse does not play audio coordinates in sleep mode#15962
Merged
Conversation
seanbudd
reviewed
Dec 27, 2023
seanbudd
reviewed
Dec 27, 2023
seanbudd
reviewed
Dec 27, 2023
seanbudd
reviewed
Dec 27, 2023
seanbudd
approved these changes
Dec 27, 2023
lukaszgo1
reviewed
Dec 27, 2023
Nael-Sayegh
pushed a commit
to Nael-Sayegh/nvda
that referenced
this pull request
Feb 15, 2024
…ess#15962) Fixes nvaccess#8059 Summary of the issue: This issue seems to be because in the core pump, mouse movement events are being handled, but when executing the mouse movement event, there is no check for whether it is in sleep mode. And the function to play audio coordinates is executed accordingly. Description of user facing changes The audio coordinates are no longer played when the mouse moves over an application in sleep mode. Description of development approach Simultaneously determine whether to report audio coordinates and whether to be in sleep mode.
SaschaCowley
pushed a commit
to SaschaCowley/nvda
that referenced
this pull request
Feb 27, 2024
…ess#15962) Fixes nvaccess#8059 Summary of the issue: This issue seems to be because in the core pump, mouse movement events are being handled, but when executing the mouse movement event, there is no check for whether it is in sleep mode. And the function to play audio coordinates is executed accordingly. Description of user facing changes The audio coordinates are no longer played when the mouse moves over an application in sleep mode. Description of development approach Simultaneously determine whether to report audio coordinates and whether to be in sleep mode.
Adriani90
pushed a commit
to Adriani90/nvda
that referenced
this pull request
Mar 13, 2024
…ess#15962) Fixes nvaccess#8059 Summary of the issue: This issue seems to be because in the core pump, mouse movement events are being handled, but when executing the mouse movement event, there is no check for whether it is in sleep mode. And the function to play audio coordinates is executed accordingly. Description of user facing changes The audio coordinates are no longer played when the mouse moves over an application in sleep mode. Description of development approach Simultaneously determine whether to report audio coordinates and whether to be in sleep mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #8059
Summary of the issue:
This issue seems to be because in the core pump, mouse movement events are being handled, but when executing the mouse movement event, there is no check for whether it is in sleep mode. And the function to play audio coordinates is executed accordingly.
Description of user facing changes
The audio coordinates are no longer played when the mouse moves over an application in sleep mode.
Description of development approach
Simultaneously determine whether to report audio coordinates and whether to be in sleep mode.
Testing strategy:
Do not play audio coordinates when moving the mouse on this application
Known issues with pull request:
I was considering the possibility of failure in the logic of updating the mouse object.
So to be on the safe side I chose to use the old mouse object for the judgment.
Although this will delay the response of a mouse object, I think it is acceptable for this PR.
Code Review Checklist: