Conversation
Closes #13333 Summary of the issue: To aid with converting to markdown, fixing txt2tags syntax issues will ensure the conversion works as expected. Note that not all syntax issues are fixed, however this PR intends to catch easy fixes that can be fixed with regex. This may result in bad syntax in the markdown files, however these are syntax issues in the current documentation so conversion is unlikely to be a step in a worse direction. Description of user facing changes None Description of development approach Regex groups: ([^`])`([^`]) replaced with $1``$2 ^ ( )*- to detect lists indented by an odd number of spaces Unmaintained files in user_docs have been removed
… `TextCtrl` (#15953) Fixes #15952 Summary of the issue: The text is updated when the mouse moves on the Speech Viewer Description of user facing changes When the mouse is in TextCtrl, the voice text is no longer updated Description of development approach Add a condition to check whether the mouse is inside the TextCtrl when determining whether to update the text
Fixes #14240 Summary of the issue: Definition lists are not exposed correctly in NVDA. They are also not supported in markdown natively. In order to convert text2tags to markdown, these must be converted to tables Description of user facing changes Definition lists are now tables in the user guide, which are exposed better by NVDA. The user guide standards have been updated to encourage the following format for documenting settings. The standards have been expanded to further document settings in a well structured manner. This is to improve readability, creating a simple standard to learn more about a settings documentation. This also allows for the future of automatically collating tables into a settings reference similar to key commands. Options Default (Enabled), Enabled, Disabled Default Enabled Toggle command nvda+shift+e Option Behaviour Enabled behaviour of enabled Disabled behaviour of enabled Description of development approach All t2t files had definition lists converted to markdown. The following regex was used to perform the conversion. To remove the definition list terminator : Find: ((^:.+\n .*\n)+): replace: $1 To replace rows: Find: ^: (.*)\n (.*)\n Replace: || $1 | $2 |\n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.