Skip to content

Merge beta to master#15954

Merged
seanbudd merged 3 commits into
masterfrom
beta
Dec 22, 2023
Merged

Merge beta to master#15954
seanbudd merged 3 commits into
masterfrom
beta

Conversation

@seanbudd

Copy link
Copy Markdown
Member

No description provided.

seanbudd and others added 3 commits December 22, 2023 10:02
Closes #13333

Summary of the issue:
To aid with converting to markdown, fixing txt2tags syntax issues will ensure the conversion works as expected.
Note that not all syntax issues are fixed, however this PR intends to catch easy fixes that can be fixed with regex.
This may result in bad syntax in the markdown files, however these are syntax issues in the current documentation so conversion is unlikely to be a step in a worse direction.

Description of user facing changes
None

Description of development approach
Regex groups:

([^`])`([^`]) replaced with $1``$2
^ (  )*- to detect lists indented by an odd number of spaces
Unmaintained files in user_docs have been removed
… `TextCtrl` (#15953)

Fixes #15952

Summary of the issue:
The text is updated when the mouse moves on the Speech Viewer

Description of user facing changes
When the mouse is in TextCtrl, the voice text is no longer updated

Description of development approach
Add a condition to check whether the mouse is inside the TextCtrl when determining whether to update the text
Fixes #14240

Summary of the issue:
Definition lists are not exposed correctly in NVDA.
They are also not supported in markdown natively.
In order to convert text2tags to markdown, these must be converted to tables

Description of user facing changes
Definition lists are now tables in the user guide, which are exposed better by NVDA.

The user guide standards have been updated to encourage the following format for documenting settings.
The standards have been expanded to further document settings in a well structured manner.
This is to improve readability, creating a simple standard to learn more about a settings documentation.
This also allows for the future of automatically collating tables into a settings reference similar to key commands.

Options	Default (Enabled), Enabled, Disabled
Default	Enabled
Toggle command	nvda+shift+e
Option	Behaviour
Enabled	behaviour of enabled
Disabled	behaviour of enabled
Description of development approach
All t2t files had definition lists converted to markdown.
The following regex was used to perform the conversion.

To remove the definition list terminator :

Find: ((^:.+\n  .*\n)+):
replace: $1
To replace rows:

Find: ^: (.*)\n  (.*)\n
Replace: || $1 | $2 |\n
@seanbudd seanbudd requested review from a team as code owners December 22, 2023 00:47
@seanbudd seanbudd merged commit b203f69 into master Dec 22, 2023
@seanbudd seanbudd added this to the 2024.2 milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants