Speech Viewer: Do not update the speech text when the mouse is on the TextCtrl#15953
Merged
Conversation
seanbudd
reviewed
Dec 21, 2023
seanbudd
approved these changes
Dec 21, 2023
5 tasks
Adriani90
pushed a commit
to Adriani90/nvda
that referenced
this pull request
Mar 13, 2024
… `TextCtrl` (nvaccess#15953) Fixes nvaccess#15952 Summary of the issue: The text is updated when the mouse moves on the Speech Viewer Description of user facing changes When the mouse is in TextCtrl, the voice text is no longer updated Description of development approach Add a condition to check whether the mouse is inside the TextCtrl when determining whether to update the text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15952
Summary of the issue:
The text is updated when the mouse moves on the Speech Viewer
Description of user facing changes
When the mouse is in
TextCtrl, the voice text is no longer updatedDescription of development approach
Add a condition to check whether the mouse is inside the
TextCtrlwhen determining whether to update the textTesting strategy:
TextCtrlSpeech text is no longer being updated
Known issues with pull request:
None
Code Review Checklist: