Skip to content

Exclude git tracked files when running scons -c#15871

Merged
seanbudd merged 2 commits into
nvaccess:masterfrom
hwf1324:fix-7070
Dec 4, 2023
Merged

Exclude git tracked files when running scons -c#15871
seanbudd merged 2 commits into
nvaccess:masterfrom
hwf1324:fix-7070

Conversation

@hwf1324

@hwf1324 hwf1324 commented Dec 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #7070
Fixes #10833

Summary of the issue:

The Clean function of comInterfaces_sconscript cleans up the files tracked by git

Description of user facing changes

None

Description of development approach

Add exclusion items in the cleanup matching function in comInterfaces_sconscript

Testing strategy:

  1. Run scons source
  2. Run scons -c
  3. Run git status
  4. Run scons source
  5. Run git status
  6. Run runnvda

Check if the tracked files in git have been deleted after observation and cleaning

Known issues with pull request:

When the tracked files in git change, the exclusion parameters need to be modified synchronously

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@hwf1324 hwf1324 requested a review from a team as a code owner December 3, 2023 16:48
@hwf1324 hwf1324 requested a review from seanbudd December 3, 2023 16:48
@CyrilleB79

CyrilleB79 commented Dec 3, 2023

Copy link
Copy Markdown
Contributor

Does it also fix #10833?
If not, is there a simple way to have this also fixed in this PR?

@hwf1324

hwf1324 commented Dec 3, 2023

Copy link
Copy Markdown
Contributor Author

Does it also fix #10833?
If not, is there a simple way to have this also fixed in this PR?

I think so, looks like #10833 is the same as #15865

@CyrilleB79

CyrilleB79 commented Dec 3, 2023

Copy link
Copy Markdown
Contributor

Does it also fix #10833?
If not, is there a simple way to have this also fixed in this PR?

I think so, looks like #10833 is the same as #15865

Cool!

§Could you add a more precise test process?

  1. Build NVDA
  2. scons -c
  3. Build NVDA again
  4. Run NVDA

Thanks
Also, could you add a change log item in the "Change for developers" section? Or in the bugfix one?

@seanbudd seanbudd marked this pull request as draft December 3, 2023 22:57
@seanbudd

seanbudd commented Dec 3, 2023

Copy link
Copy Markdown
Member

Also please link all fixed issues in the issue description

e.g.
Fixes # 123
Fixes # 256

@hwf1324 hwf1324 marked this pull request as ready for review December 4, 2023 03:58
@seanbudd seanbudd merged commit 604d7bf into nvaccess:master Dec 4, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Dec 4, 2023
@hwf1324 hwf1324 deleted the fix-7070 branch December 4, 2023 05:27
@hwf1324 hwf1324 mentioned this pull request Jan 23, 2024
Merged
5 tasks
seanbudd pushed a commit that referenced this pull request Jan 23, 2024
@hwf1324
Improve comInterfaces readme (#16085)
e324e08 
Related #15871

Summary of the issue:
Add instructions for manually adding files to source/comInterfaces.
Nael-Sayegh pushed a commit to Nael-Sayegh/nvda that referenced this pull request Feb 15, 2024
@hwf1324 @Nael-Sayegh
Improve comInterfaces readme (nvaccess#16085)
f18f95f 
Related nvaccess#15871

Summary of the issue:
Add instructions for manually adding files to source/comInterfaces.
SaschaCowley pushed a commit to SaschaCowley/nvda that referenced this pull request Feb 27, 2024
@hwf1324
Improve comInterfaces readme (nvaccess#16085)
89201ec 
Related nvaccess#15871

Summary of the issue:
Add instructions for manually adding files to source/comInterfaces.
Adriani90 pushed a commit to Adriani90/nvda that referenced this pull request Mar 13, 2024
@hwf1324 @Adriani90
Improve comInterfaces readme (nvaccess#16085)
1ccbfda 
Related nvaccess#15871

Summary of the issue:
Add instructions for manually adding files to source/comInterfaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2024.1

Development

Successfully merging this pull request may close these issues.

scons --clean deletes some files that are fetched from the repo source/comInterfaces contains some files which should be ignored

4 participants

@hwf1324 @CyrilleB79 @seanbudd @nvaccessAuto