Conversation
Contributor
|
#15796 has been reported by at least two persons (@cary-rowen and myself). And the very bad resulting UX was that NVDA needs to be restarted due to a never closing progress dialog. |
michaelDCurran
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15796
Summary of the issue:
Sometimes an add-on file fails to download correctly.
This causes an error that isn't recoverable without notification to the user.
Description of user facing changes
If an add-on download file cannot be successfully loaded as a zipfile, warn the user that the installation has failed and let the user continue with their tasks.
in my opinion this fix is not worthy of a changelog entry
Description of development approach
Catch error
Testing strategy:
test by manually giving
zipfilea bad file path in source codeKnown issues with pull request:
doesn't fix unknown rare underlying error, but this is much better handling
Code Review Checklist: