Changes: grammatical fixes, and mention of fixed bug with the whatsapp voice messages#15840
Merged
Merged
Conversation
Contributor
|
Thanks for mentioning the common bug with Whatsapp Desktop. Regarding the rest of the changes related to credits:
|
Contributor
Author
|
Hi, |
Contributor
|
It is not up to your decision how to write handles.
If Leonard decided that, you don't have rights to change that.
You also don't have right to mention a credit before asking other
people. Person might not to be agree to nclude their names.
…On 11/27/23, Zvonimir Stanečić ***@***.***> wrote:
Hi,
lets comment all your points
• Credits needs to be asked by users themselves. So you should not add
credit for other people than yourself, overall without asking them (or did
you?).
Why i should ask them? It is in a good faith, moral to mention the credits.
I thought that it is unintentional and forgotten.
@LeonarddeR
has a github name by all lowercase. as the documentation uses github names
as a references to contributor, it is healthier to fix this.
--
Reply to this email directly or view it on GitHub:
#15840 (comment)
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
--
with best regards Beqa Gozalishvili
Tell: +995593454005
Email: ***@***.***
Web: https://gozaltech.org
Skype: beqabeqa473
Telegram: https://t.me/gozaltech
facebook: https://facebook.com/gozaltech
twitter: https://twitter.com/beqabeqa473
Instagram: https://instagram.com/beqa.gozalishvili
|
Contributor
Author
|
Done, reverted.
…--
Ta wiadomość e-mail została sprawdzona pod kątem wirusów przez oprogramowanie antywirusowe Avast.
www.avast.com
|
Collaborator
|
I have just fixed the casing of my user name, changed it to @LeonarddeR |
Contributor
Author
|
Okay.
Just reverted
…--
Ta wiadomość e-mail została sprawdzona pod kątem wirusów przez oprogramowanie antywirusowe Avast.
www.avast.com
|
seanbudd
reviewed
Nov 27, 2023
| - NVDA should remain responsive when being flooded with many UI Automation events, e.g. large amounts of text in a terminal. (#14888) | ||
| - This new behavior can be disabled using the new Use enhanced event processing setting in NVDA's advanced settings. | ||
| - NVDA should remain responsive when being flooded with many UI Automation events, e.g. when the large pieces of text are sent to terminal or when listening to voice messages in WhatsApp messenger. (#14888, #15169) | ||
| - This new behavior can be disabled using the new Use enhanced event processing setting in NVDA's advanced settings. |
Member
There was a problem hiding this comment.
the list terminator below must match the indentation change
| - NVDA now resumes audio if the configuration of the output device changes or another application releases exclusive control of the device. (#15758, #15775, @jcsteh) | ||
| - NVDA should remain responsive when being flooded with many UI Automation events, e.g. large amounts of text in a terminal. (#14888) | ||
| - This new behavior can be disabled using the new Use enhanced event processing setting in NVDA's advanced settings. | ||
| - NVDA should remain responsive when being flooded with many UI Automation events, e.g. when the large pieces of text are sent to terminal or when listening to voice messages in WhatsApp messenger. (#14888, #15169) |
Member
There was a problem hiding this comment.
Grammar fixes:
Suggested change
| - NVDA should remain responsive when being flooded with many UI Automation events, e.g. when the large pieces of text are sent to terminal or when listening to voice messages in WhatsApp messenger. (#14888, #15169) | |
| - NVDA should remain responsive when being flooded with many UI Automation events, e.g. when large chunks of text are printed to a terminal or when listening to voice messages in WhatsApp messenger. (#14888, #15169) |
seanbudd
reviewed
Nov 27, 2023
217b31c to
021c13d
Compare
Contributor
Author
|
it should be applied now along with resolved conflicts from master |
Contributor
Author
|
@seanbudd |
seanbudd
reviewed
Dec 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
none
Summary of the issue:
This pull request adds mention about the fact that the whatsapp voice messages no longer freeze nvda as per #15169, and #14888.
This pull request also fixes some mistakes and typos
Description of user facing changes
Fixes for the documentation
Description of development approach
Edited the english changes.t2t
Testing strategy:
tested locally that the HTML is generated
Known issues with pull request:
None
Code Review Checklist: