Fix inaccurate text reporting in Visual Studio text controls#15838
Merged
Conversation
Member
|
Is this a regression fix? should there be a change log entry? |
Collaborator
Author
|
It indeed fixes a regression caused by the new UIA implementation in 14888, so a changelog entry shouldn't be needed.
|
michaelDCurran
added a commit
that referenced
this pull request
Feb 14, 2024
8 tasks
seanbudd
pushed a commit
that referenced
this pull request
Jul 11, 2024
Partially reverts #14888, #15838 Summary of the issue: In #14888, XamlEditableText was added to ensure that UIA events wouldn't be used to determine caret changes, as the hypothesis was that they were fired too early. In #15838, I expanded this workaround for WPF (Visual Studio) text controls. It turns out @jcsteh found the actual cause of these issues and fixed them in #16711, allowing us to rely on events again. Description of user facing changes None, though caret movement would possibly be detected a little bit faster in XAML and WPF controls. Description of development approach Mostly reverts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
follow up of #14888
Summary of the issue:
During development of #14888, it was observed that XAML edit fields tend to fire text change events before the caret position is changed, resulting in wrong text reporting. After using Visual Studio, I discovered that the same issue applies to the text controls in Visual Studio, notably WPF.
Description of user facing changes
In Visual Studio, the caret position is no longer sometimes reported inaccurately.
Description of development approach
use a common base class for XAML and WPF editable text.
Testing strategy:
Tested that caret reporting is again accurate in Visual Studio.
Known issues with pull request:
None known
Code Review Checklist: