Skip to content

Python console small improvements#15794

Merged
michaelDCurran merged 3 commits into
nvaccess:masterfrom
CyrilleB79:pyCons
Nov 19, 2023
Merged

Python console small improvements#15794
michaelDCurran merged 3 commits into
nvaccess:masterfrom
CyrilleB79:pyCons

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

Closes #15792
Closes #15793

Summary of the issue:

  1. When going back in the Python console history, modifying a line modifies the history. As a consequence, some previous commands cannot be found anymore in the console history.
  2. The clear command control+L in the console does not provide any feedback

Description of user facing changes

  1. When going back in the console history, editing a line will not change the item in the history anymore
  2. Clearing the console output with control+L will now report a confirmation message.

Description of development approach

  1. Remove the line of code that was updating an item in the history. It seemed to be done on purpose, but it seems not appropriate. Maybe it was intended for the last line? I may restore it for the last (empty) line if NV Access wants.
  2. Trivial

Testing strategy:

Manual test

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review November 16, 2023 16:37
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner November 16, 2023 16:37
@CyrilleB79 CyrilleB79 requested a review from seanbudd November 16, 2023 16:37
@michaelDCurran michaelDCurran merged commit 916dbb9 into nvaccess:master Nov 19, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Nov 19, 2023
@CyrilleB79 CyrilleB79 deleted the pyCons branch November 20, 2023 21:13
seanbudd pushed a commit that referenced this pull request Jun 6, 2024
#16654)

Closes #16653

Summary of the issue:
Unexecuted commands are lost when moving in the python console history.

Description of user facing changes
If a command has been written or modified in the console but not executed, it will not be lost. In case the modified command is not the last in the history, the original history item will not be overriden (as it was before #15794), but it will be copied in last position in the history so that it can be edited.

Description of development approach
Tracked text modification with an appropriate event to react accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No feedback when clearing the python console output Do not allow to rewrite Python console history

3 participants