Skip to content

Restore support for brltty#15658

Merged
seanbudd merged 3 commits intonvaccess:masterfrom
LeonarddeR:brlapi
Oct 26, 2023
Merged

Restore support for brltty#15658
seanbudd merged 3 commits intonvaccess:masterfrom
LeonarddeR:brlapi

Conversation

@LeonarddeR
Copy link
Copy Markdown
Collaborator

@LeonarddeR LeonarddeR commented Oct 20, 2023

Link to issue number:

Fixes #15652
See also nvaccess/nvda-misc-deps#28

Summary of the issue:

BRLTTY support was temporarily acknowledged as broken as part of #15544.

Description of user facing changes

None

Description of development approach

  1. Update misc deps
  2. Re-enable the brlapi test

Testing strategy:

Execute scons dist and run the generated NVDA distribution. Execute import brlapi from the Python Console.

Known issues with pull request:

None known

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd marked this pull request as ready for review October 26, 2023 01:48
@seanbudd seanbudd requested a review from a team as a code owner October 26, 2023 01:49
@seanbudd seanbudd removed the blocked label Oct 26, 2023
@seanbudd seanbudd merged commit 717f217 into nvaccess:master Oct 26, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Oct 26, 2023
LeonarddeR added a commit to LeonarddeR/nvda that referenced this pull request Oct 26, 2023
seanbudd pushed a commit that referenced this pull request Oct 26, 2023
@LeonarddeR LeonarddeR deleted the brlapi branch August 23, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore BRLTTY support

3 participants