Conversation
michaelDCurran
approved these changes
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15411
Summary of the issue:
When unchecking 'Include incompatible add-ons', incompatible add-ons are still included in the list.
This is due to the cache of the compatible add-ons being updated to include incompatible add-ons.
This is due to a referencing problem, where the listed add-ons and the compatible add-on cache used the same reference.
Description of user facing changes
Unchecking "include incompatible add-ons" should now correctly return the list to only show compatible add-ons
Description of development approach
A copy of the cache should be used instead, to prevent external functions from updating the cached copy.
Testing strategy:
Manually test STR in #15411
Known issues with pull request:
None
Change log entries:
refer to diff
Code Review Checklist: