Skip to content

Add-on store: correctly refresh cache when filtering incompatible add-ons#15418

Merged
seanbudd merged 2 commits into
betafrom
fix-15411
Sep 11, 2023
Merged

Add-on store: correctly refresh cache when filtering incompatible add-ons#15418
seanbudd merged 2 commits into
betafrom
fix-15411

Conversation

@seanbudd

@seanbudd seanbudd commented Sep 11, 2023

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #15411

Summary of the issue:

When unchecking 'Include incompatible add-ons', incompatible add-ons are still included in the list.
This is due to the cache of the compatible add-ons being updated to include incompatible add-ons.
This is due to a referencing problem, where the listed add-ons and the compatible add-on cache used the same reference.

Description of user facing changes

Unchecking "include incompatible add-ons" should now correctly return the list to only show compatible add-ons

Description of development approach

A copy of the cache should be used instead, to prevent external functions from updating the cached copy.

Testing strategy:

Manually test STR in #15411

Known issues with pull request:

None

Change log entries:

refer to diff

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner September 11, 2023 05:52
@seanbudd seanbudd requested review from michaelDCurran and removed request for a team September 11, 2023 05:52
@seanbudd seanbudd added this to the 2023.3 milestone Sep 11, 2023
@seanbudd seanbudd merged commit 35be3e0 into beta Sep 11, 2023
@seanbudd seanbudd deleted the fix-15411 branch September 11, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants