Conversation
Closes #15362 Summary of the issue: "Add-on store" item has been added with "S" as a shortcut key in NVDA tools menu in NVDA 2023.2. Unfortunately "S" was already used for "Speech viewer" (as its first letter), even if it was not defined explicitly. Now that there is an explicit mapping for "Add-on store", implicit shortcut key definition for "Speech viewer" becomes masked and does not work anymore. In case the add-ons add new items in the menus with explicit definition of shortcut keys, other menu item that only use implicit definition of the shortcut key may be masked as well. Description of user facing changes Explicitly define shortcut keys in main NVDA menu and avoid collisions (i.e. two times the same letter in the same menu). Description of development approach In main NVDA menu: "Tools: add explicitly "T" "Reset configuration to factory defaults")": Change "R" to "F" because was already used by "Revert to saved configuration" "Donate": add explicitly "D" In "Tools" submenu: "Reload plugins e": change "R" to "E" since "R" already taken by "Run COM Registration Fixing tool..." "Add-on store": "A" instead of "S", as discussed in Speech viewer no longer has a shortcut key in the tools menu in 2023.2 #15362 (comment), to avoid collision with "Speech viewer" "View log": "L" instead of "V" to be more intuitive, as discussed in NVDA menu: add explicit shortcut keys and avoid collisions #15364 (comment) For all other items, explicitly mark the accelerator Help menu: "About": Explicitly set "A" All other items are already explicitly marked.
Reintroduces #14285 Fixes #15375 Fixes #15330 Reverts #15314 Summary of the issue: In #15314, edit and rich edit classes were no longer classified as bad for UIA. This caused the following issues: Read only edit fields in Explorer no longer read correctly, as they inherrit from both UIA and IAccessible UIA adds a redundant name of RichEdit Control to RichEdit controls. Generally spoken, removing these classes from the bad UIA classes list meant an API breaking change because Edit objects using UIA instead of legacy Edit support behave differently with regard to overriding and filtering texts, including LTR and RTL marks. Description of user facing changes Reverted #15314. Most notably, the lag as reported in #14285 will unfortunately be reintroduced for now. Description of development approach Re-add the bad UIA class names again. Addressed issues in the explorer appmodule as pointed out in Edit controls in explorer fail when they have a native UIA implementation #15375. Most notably, changed class inheritance from IAccessible to Edit Added some small checks to overlay selection to ensure SysListView overlays won't be added on SysListView objects that don't use MSAA
…hange events (#15377) Fixes #15230 Summary of the issue: NVDA's calculation announcements for Win32 calculator relies on a list of predefined keyboard commands, which, when pressed, causes the new value of the display to be announced. This assumes that at the time when gesture is sent the calculator had enough time to process it, and display the result of the calculation. While this worked before prior to #14708, after this PR NVDA no longer sleeps after sending gestures, therefore the value on calculator's display had not enough time to be updated. For users this means that after performing calculations the outdated value was read. Description of user facing changes NVDA once again announces correct results of the calculation. Description of development approach Rather than announcing the display value immediately after user pressed a key, NVDA now sets a flag signaling that the given command causes result of a calculation to appear. This flag is checked in the name change event for the display. If it is set the result is announced and the flag is restored to its default value. While at it I have also updated the copyright header of the module based on its log in VCS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.