Conversation
Fixes #15347 Summary of the issue: #15347 raises 2 issues with handling the results of downloading add-ons when the add-on list has been refreshed by switching to a different add-on list view tab. This is due to the download task relying on an add-on being visible in the add-on list. Description of user facing changes Installing add-ons and then switching tabs should not result in any errors and downloads should be successful Description of development approach Up the max workers for downloading to 10, meaning up to 10 add-ons can be downloaded simultaneously Fix handling of completed downloads to be safer, use the list view model for downloading rather than just the add-on model so that the context of the add-on list view is not needed Fix up various misleading typing annotations Add an "UNKNOWN" category for add-on status rather than just causing an error, this will allow add-ons with an unknown status to appear in the incompatible add-ons tab instead of just being hidden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.