Skip to content

Fix background downloading of add-ons#15379

Merged
seanbudd merged 1 commit into
betafrom
fixBackgroundDL
Sep 6, 2023
Merged

Fix background downloading of add-ons#15379
seanbudd merged 1 commit into
betafrom
fixBackgroundDL

Conversation

@seanbudd

@seanbudd seanbudd commented Sep 6, 2023

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #15347

Summary of the issue:

#15347 raises 2 issues with handling the results of downloading add-ons when the add-on list has been refreshed by switching to a different add-on list view tab.
This is due to the download task relying on an add-on being visible in the add-on list.

Description of user facing changes

Installing add-ons and then switching tabs should not result in any errors and downloads should be successful

Description of development approach

  • Up the max workers for downloading to 10, meaning up to 10 add-ons can be downloaded simultaneously
  • Fix handling of completed downloads to be safer, use the list view model for downloading rather than just the add-on model so that the context of the add-on list view is not needed
  • Fix up various misleading typing annotations
  • Add an "UNKNOWN" category for add-on status rather than just causing an error, this will allow add-ons with an unknown status to appear in the incompatible add-ons tab instead of just being hidden

Testing strategy:

Tested STR in #15347 with help from #15350 to stress test large downloads of multiple add-ons

Known issues with pull request:

None

Change log entries:

Bug fixes

* Fixed add-on store bug when downloading multiple add-ons (#15347)
* Fixed add-on store bug when downloading add-ons and changing tabs (#15347)

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner September 6, 2023 01:26
@seanbudd seanbudd requested review from michaelDCurran and removed request for a team September 6, 2023 01:26
@seanbudd seanbudd added this to the 2023.3 milestone Sep 6, 2023
@AppVeyorBot

AppVeyorBot commented Sep 6, 2023

Copy link
Copy Markdown

See test results for failed build of commit 3902a632cf

@seanbudd seanbudd merged commit 2f1971a into beta Sep 6, 2023
@seanbudd seanbudd deleted the fixBackgroundDL branch September 6, 2023 07:06
@seanbudd seanbudd mentioned this pull request Sep 12, 2023
Merged
6 tasks
seanbudd added a commit that referenced this pull request Sep 12, 2023
@seanbudd
Fix up bugs with multi downloads (#15429)
015d4b7 
Fixup of #15379

Summary of the issue:
There are some bugs with downloading multiple add-ons at once:

when switching tab "downloading" status is lost
if downloads are cancelled and restarted subsequently some errors occur
Description of user facing changes
When switching tab "downloading" status is no longer lost.
Make cancelling downloads safer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelDCurran michaelDCurran michaelDCurran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2023.3

Development

Successfully merging this pull request may close these issues.

3 participants

@seanbudd @AppVeyorBot @michaelDCurran