Conversation
Fixes #15233 Summary of the issue: Unfortunately pr #14900 causes Code Factory Eloquence to spell out menu items with shortcut keys, such as in the NVDA menu. Description of user facing changes Menu items are no longer spelled out when focusing menu items when using the Code Factory Eloquence driver. Description of development approach Although the bug is technically in the Code Factory driver I think - not handlin character mode command correctly when embedded in other speech, PR 14900 is the first known case that exercises the bug directly. Because 2023.2 is not an add-on breaking release, we are reverting pr #14900. A replacement pr for 2023.3 can be opened that avoids affecting Code Factory Eloquence if at all possible, or a new copy of the reverted pr can be opened for NVDA 2024.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.