Skip to content

Fix up Eurobraille device detection and gestures#15208

Merged
seanbudd merged 2 commits into
betafrom
fixupEurobrailleGestures
Jul 28, 2023
Merged

Fix up Eurobraille device detection and gestures#15208
seanbudd merged 2 commits into
betafrom
fixupEurobrailleGestures

Conversation

@seanbudd

@seanbudd seanbudd commented Jul 28, 2023

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #15204

Summary of the issue:

Device names with a period in them are invalid.
This causes an error when loading the input gestures dialog.

Description of user facing changes

Error should no longer be logged when opening input gestures dialog

Description of development approach

Change device names from b.book and b.note to bbook and bnote

Testing strategy:

Confirm with testers that b.book and b.note still work as expected

Known issues with pull request:

None

Change log entries:

N/A

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner July 28, 2023 02:37
@seanbudd seanbudd requested review from michaelDCurran and removed request for a team July 28, 2023 02:37
@seanbudd seanbudd added this to the 2023.2 milestone Jul 28, 2023
michaelDCurran
michaelDCurran previously approved these changes Jul 28, 2023
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit fa13581b67

@seanbudd seanbudd merged commit 34bf95a into beta Jul 28, 2023
@seanbudd seanbudd deleted the fixupEurobrailleGestures branch July 28, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants