Steps to reproduce:
- Plug braille display
- Start NVDA
- Open the input gesture dialog
Actual behavior:
The following errors are logged:
ERROR - braille.BrailleDisplayGesture.getDisplayTextForIdentifier (16:48:20.120) - MainThread (12068):
Invalid braille gesture identifier: br(eurobraille.b.note):joystick1left
ERROR - braille.BrailleDisplayGesture.getDisplayTextForIdentifier (16:48:20.128) - MainThread (12068):
Invalid braille gesture identifier: br(eurobraille.b.note):joystick1right
I have not checked if there are other consequences.
Expected behavior:
No error
NVDA logs, crash dumps and other attachments:
Not provided
System configuration
NVDA installed/portable/running from source:
Installed
NVDA version:
2023.2beta1
Windows version:
Windows 10 21H2 (AMD64) build 19044.3208
Name and version of other software in use when reproducing the issue:
N/A
Other information about your system:
Using Braille display: Esys80
Other questions
Does the issue still occur after restarting your computer?
Not tested
Have you tried any other versions of NVDA? If so, please report their behaviors.
I remember that there was no issue with NVDA 2023.1
If NVDA add-ons are disabled, is your problem still occurring?
Yes
Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?
Not tested
Technical notes
In the class BrailleDisplayGesture in braille.py we have:
#: Compiled regular expression to match an identifier including an optional model name
#: The model name should be an alphanumeric string without spaces.
#: @type: RegexObject
ID_PARTS_REGEX = re.compile(r"br\((\w+)(?:\.(\w+))?\):([\w+]+)", re.U)
And see also the documentation of _get_model method.
Both indicate that this means that the model names should be an alphanumeric string without space. Given the implementation with \w, it can only contain letters and digits as well as underscore. Thus, "b.note" is not allowed since it contains a dot.
Cc @FalkoBabbage, @LeonarddeR
Steps to reproduce:
Actual behavior:
The following errors are logged:
I have not checked if there are other consequences.
Expected behavior:
No error
NVDA logs, crash dumps and other attachments:
Not provided
System configuration
NVDA installed/portable/running from source:
Installed
NVDA version:
2023.2beta1
Windows version:
Windows 10 21H2 (AMD64) build 19044.3208
Name and version of other software in use when reproducing the issue:
N/A
Other information about your system:
Using Braille display: Esys80
Other questions
Does the issue still occur after restarting your computer?
Not tested
Have you tried any other versions of NVDA? If so, please report their behaviors.
I remember that there was no issue with NVDA 2023.1
If NVDA add-ons are disabled, is your problem still occurring?
Yes
Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?
Not tested
Technical notes
In the class
BrailleDisplayGestureinbraille.pywe have:And see also the documentation of
_get_modelmethod.Both indicate that this means that the model names should be an alphanumeric string without space. Given the implementation with \w, it can only contain letters and digits as well as underscore. Thus, "b.note" is not allowed since it contains a dot.
Cc @FalkoBabbage, @LeonarddeR