Restore numpad gestures for move in flatten view of object hierarchy commands for all keyboard layouts#15191
Merged
Merged
Conversation
…commands for all keyboard layouts
Collaborator
|
Thanks @CyrilleB79 If you aim to have this in 2023.2, you need to retarget to beta. |
Contributor
Author
|
Note: Proposed against beta since the changes are minimal and related to a PR introduced during 2023.2 dev cycle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #15185
Follow-up of #15065.
Summary of the issue:
New gestures to move in flattened object hierarchy have been added in #15065: nvda+numpad3/9 for desktop layout and shift+NVDA+[ / ] for laptop layout.
Although mainly used with desktop layout, object nav-related gestures associated to numpad are usually bound to all keyboard layout (desktop and laptop). This allows for example users to have NVDA to be configured with laptop layout for a laptop computer without numpad on its keyboard, but to use the numpad gestures in case an external keyboard with numpad is plugged in.
Description of user facing changes
The gestures NVDA+numpad3/9 for the new flattened object navigation commands will now be available both in laptop and in desktop mode.
As done for other obj nav gestures, the user guide (and the change log) still advertises numpad gestures for desktop layout only.
Description of development approach
Changed the gesture definition.
Testing strategy:
Known issues with pull request:
I have used:
git grep "desktop.*numpad"and found two other places where numpad shortcuts are used in desktop only:
However, I have not been able to test them. They seem to be part of rarely used code and nobody complained of it until now. So I have not changed them.
Change log entries:
Not needed (unreleased feature)
Code Review Checklist: