Conversation
See test results for failed build of commit 23a5c5766b |
michaelDCurran
approved these changes
Jul 3, 2023
This was referenced Sep 11, 2024
seanbudd
pushed a commit
that referenced
this pull request
Sep 17, 2024
) Fixes #17157 Fixup of #14133 Partially reverts #15074 Summary of the issue: When saving configuration profiles, unchanged values are yet saved to a profile. Description of user facing changes Configuration profiles should become less polluted after this change. Description of development approach Restored the behavior of #14133, mostly reverting #15074. There was namely a False assumption in #15074. @seanbudd wrote: This caused various issues including config values not being correctly converted to numbers from strings when validating. In fact, the validation was not the problem here. Instead, when __getitem__ was called with checkValidity set to False, the unvalidated value was yet saved in the cache. Therefore subsequent calls of __getitem__ would always return the unvalidated cached value that would always be of the string type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #14760
Fixup of #14133
Summary of the issue:
When saving a config spec, validation would be skipped if the string value of the data is unchanged.
This caused various issues including config values not being correctly converted to numbers from strings when validating.
This caused config profiles to fail to load or save correctly.
Description of user facing changes
Fix up of various bugs related to user config
Description of development approach
Perform special handling that was introduced in #14133 for feature flags only
Testing strategy:
Test STR outlined in #14760 (comment)
Known issues with pull request:
None
Change log entries:
Bug fixes
Code Review Checklist: