Skip to content

Add-on store - Clarify window title and list label#15054

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:addonStoreTitle
Jun 27, 2023
Merged

Add-on store - Clarify window title and list label#15054
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:addonStoreTitle

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #15042

Summary of the issue:

The title of add-on store window is formatted such as "Add-on Store - All Installed add-ons"
After the dash, the string is a concatenation of the channel and the type of add-ons in the list.

  • In English,it makes something almost grammatically correct to build a single expression (if we ignore case). But in other languages, this concatenation without any separator may produce stranger results that sound bad.
  • Also, it has been noted that the type of add-on listed ("Available add-ons" in this example) is much more important than the channel; thus it should come first.

Description of user facing changes

  • Reworked the window title to create a title such as "Add-on Store - Installed add-ons (All)"
  • While at it, also removed the channel in the list name as pointed in Modify the add-on store title bar text #15042 (comment), that is, the list's name is now "Available add-ons" instead of "All Available add-ons" so that the list name is less verbose.

Description of development approach

Implemented changes described below.

Note: I have used parenthesis for the channel, but I may have used a second dash as a separator instead, i.e. "Add-on store - Available add-ons - All". Let me know if you prefer this second version.

Testing strategy:

Manually checked the window title and the list name.

Known issues with pull request:

Change log entries:

Not needed on unreleased code

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review June 23, 2023 22:37
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner June 23, 2023 22:37
@CyrilleB79 CyrilleB79 requested a review from seanbudd June 23, 2023 22:37
@XLTechie

XLTechie commented Jun 24, 2023 via email

Copy link
Copy Markdown
Collaborator

@CyrilleB79

Copy link
Copy Markdown
Contributor Author

I might prefer: Available add-ons (showing all) Available add-ons (showing stable) Though if that is not liked, I am fine with how @CyrilleB79 has done it, and prefer the parenthetical expression to hyphenation.

If we do not change the casing for channel names (that begin with a capital), we would rather have "Available add-ons (showing All)" with "All" beginning with a capital letter.

Personally however, I prefer the current wording "Available add-ons (All)" to @XLTechie's suggestion "Available add-ons (showing All)". Adding "showing" is just more verbose IMO.

For a similar GUI example in MS Outlook, when you open an e-mail, the window title is "This is the subject - Message (HTML)" and not something more verbose such as "This is the subject - Message (format is HTML)".

It's just my opinion though. And I will implement what NVAccess and the community prefer. Let's wait for other feedback if any.

@cary-rowen

Copy link
Copy Markdown
Contributor

@CyrilleB79 wrote:

Personally however, I prefer the current wording "Available add-ons (All)" to @XLTechie 's suggestion "Available add-ons (showing All)". Adding "showing" is just more verbose IMO.

i totally agree

@seanbudd seanbudd merged commit ff4de2c into nvaccess:master Jun 27, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jun 27, 2023
@CyrilleB79 CyrilleB79 deleted the addonStoreTitle branch June 27, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify the add-on store title bar text

5 participants