-
-
Notifications
You must be signed in to change notification settings - Fork 784
Modify the add-on store title bar text #15042
Copy link
Copy link
Closed
Labels
component/i18nexisting localisations or internationalisationexisting localisations or internationalisationfeature/addon-storeFeatures / behavior of the add-on StoreFeatures / behavior of the add-on Storegood first issuegithub features these at https://github.com/nvaccess/nvda/contributegithub features these at https://github.com/nvaccess/nvda/contributep4https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Milestone
Description
Metadata
Metadata
Assignees
Labels
component/i18nexisting localisations or internationalisationexisting localisations or internationalisationfeature/addon-storeFeatures / behavior of the add-on StoreFeatures / behavior of the add-on Storegood first issuegithub features these at https://github.com/nvaccess/nvda/contributegithub features these at https://github.com/nvaccess/nvda/contributep4https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Steps to reproduce:
Actual behavior:
NVDA reports:
"Add-on Store - All Installed add-ons"
Expected behavior:
NVDA should report:
"Add-on Store - Installed add-ons (All)"
Indeed, the "Installed add-ons" information is more important than the "All" filter value.
Also, in English, by chance, "All Installed add-ons" sounds like "All installed add-ons" (note the difference in case). That means that concatenating a filter value and a tab name, by chance, allows to create a grammatically correct single expression (if you ignore the case). But in translations it does not sound so good as discussed in this thread on the translators mailing list.
IMO it's safer (regarding potential translation issues) to concatenate unrelated values explicitly, i.e. adding parenthesis or dash in between, rather than trying to solve this problem with a translatable compound string such as
"{channel} {tabName}".NVDA logs, crash dumps and other attachments:
N/A
System configuration
NVDA installed/portable/running from source:
portable
NVDA version:
Version: alpha-28477,50ef7d38 (2023.2.0.28477)
Windows version:
10
Name and version of other software in use when reproducing the issue:
N/A
Other information about your system:
N/A
Other questions
Does the issue still occur after restarting your computer?
Yes
Have you tried any other versions of NVDA? If so, please report their behaviors.
N/A
If NVDA add-ons are disabled, is your problem still occurring?
N/A
Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?
N/A