Link to issue number:

Fixes #15000

Summary of the issue:

Dialogs used when installing, enabling, or upgrading to, incompatible add-ons, asked yes or no questions to the user.
However, such dialogs used OK and Cancel as their buttons, which didn't really make sense.

Description of user facing changes

These three dialogs now have Yes and No buttons.

Incidentally, added a newline before the question in each dialog, as commented in the original issue. This can be reverted separately if undesirable.

Description of development approach

• Replaced the ErrorAddonInstallDialogWithCancelButton class, with a new class called ErrorAddonInstallDialogWithYesNoButtons.
• Removed ErrorAddonInstallDialogWithCancelButton, since it wasn't used anywhere other than for these three dialogs in gui/_addonStoreGui/controls/messageDialogs.py.
• Added a newline to separate explanation from actual question in these dialogs.
• Enhanced (hopefully) some translator comments I noticed along the way, as follow:
  • Created a more accurate translator comment for the incomparable version during update message.
  • Made the translator comment less ambiguous, for the message used when an add-on is being installed but is too old to be compatible.
  • Made the translator comment more accurate, for the message used when enabling an add-on too old to be compatible.
  • Fixed a typo in another translator comment.

Testing strategy:

• Manually tested installing an incompatible add-on.
• Manually tested enabling an incompatible add-on.

Haven't tested the case where an installed add-on version string is not able to be compared to a store version, but the dialog usage is the same as the other cases so it is likely to work as well as it did before this PR.

Known issues with pull request:

Even though the default button is set to "no" in these dialogs, "About add-on" is the focused default when their used.
This was true before as well with the "Cancel" button.
I'm not quite sure why SetDefault() is being ignored.

Change log entries:

The store is pre-release, none should be needed.

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• Security precautions taken.