-
-
Notifications
You must be signed in to change notification settings - Fork 786
Add-on Store: Add-on incompatible / too old dialog: switch from OK/Cancel, to Yes/No #15000
Copy link
Copy link
Closed
Labels
feature/addon-storeFeatures / behavior of the add-on StoreFeatures / behavior of the add-on Storegood first issuegithub features these at https://github.com/nvaccess/nvda/contributegithub features these at https://github.com/nvaccess/nvda/contributep5https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Milestone
Metadata
Metadata
Assignees
Labels
feature/addon-storeFeatures / behavior of the add-on StoreFeatures / behavior of the add-on Storegood first issuegithub features these at https://github.com/nvaccess/nvda/contributegithub features these at https://github.com/nvaccess/nvda/contributep5https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Is your feature request related to a problem? Please describe.
The dialog that appears when a user attempts to install an add-on which is too old--untested with this version of NVDA (for versions of NVDA of 2023.2 and above), asks the following:
To respond to that question, the following buttons are provided:
Describe the solution you'd like
Replace OK and Cancel with Yes and No.
Additional context and alternative
A question is being asked which has a definite yes or no answer. "OK" is not a definite yes answer.
"Cancel" is reasonable, to end the installation attempt, so I suppose "Continue" and "Cancel" would be acceptable; but "Yes" and "No" are more common, and are easily coded.
Additional comments
Suggest the same changes for the downgrade question (message starting on line 41 of messageDialogs.py), and correction to "new" (s/b "newer") on line 44 there.
Shouldn't "Proceed with installation anyway? " be on its own line in these dialogs?