Report the state of cell formatting when using formatting shortcuts in Excel#14923
Merged
michaelDCurran merged 3 commits intoMay 15, 2023
Merged
Conversation
See test results for failed build of commit 36d2ad3a68 |
5e35658 to
1ac1c5a
Compare
michaelDCurran
approved these changes
May 15, 2023
josephsl
pushed a commit
to josephsl/nvda
that referenced
this pull request
May 16, 2023
…n Excel (nvaccess#14923) In Excel, when applying formatting to cells, nothing is reported. Instead, in Word, toggling bold, italic or underline is reported. Description of user facing changes When using Excel shortcuts to toggle the format of a full cell in Excel, the result is now reported. The following toggle are supported: • bold: control+b or control+shift+2 • italic: control+I or control+shift+3 • underline: control+U or control+shift+4 • strikethrough: control+shift+5 (Note: did not find any other shortcut for it) Description of development approach • As done for Word text, use object model to look at the properties of the cell after the shortcut is executed. • Copied the polling function of Word's code to check for value changes polling the object model. (I had initially thought that it was not required, but testing on another system, I have found that it was required) • Implement the scripts on the whole worksheet so that the scripts work either on single cell or on multi-cell selections. Taking advantage that both excelCellObject and excelRangeObject have a font attribute.
5 tasks
seanbudd
pushed a commit
that referenced
this pull request
Sep 26, 2023
Fixes #15506 Fix-up of #14923 Summary of the issue: When peforming tests for #14923, I have wrongly assumed that Excel cell formatting shortcuts were control+shift+2/3/4/5. This assumption was based on my tests with Excel's interface changed to English on my system. However, it seems that the keyboard layout when Excel is started has also an impact on the shortcuts containing digits (see discussion in #14923). The actual shortcuts are control+2/3/4/5, as described in Microsoft documentation and as confirmed starting Excel with English GUI and English keyboard layout. Description of user facing changes On English systems (and probably many others), Excel cell formatting shortcuts control+2/3/4/5 will have their effect reported correctly. shift+control+2/3/4/5 will not report inappropriately formatting information on English systems. Description of development approach Modified the gesture definition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: Modifications that I have done time ago for myself when working with Excel sheets.
Link to issue number:
None
Summary of the issue:
In Excel, when applying formatting to cells, nothing is reported. Instead, in Word, toggling bold, italic or underline is reported.
Description of user facing changes
When using Excel shortcuts to toggle the format of a full cell in Excel, the result is now reported. The following toggle are supported:
Description of development approach
excelCellObjectandexcelRangeObjecthave afontattribute.Testing strategy:
Tested all listed shortcuts on single cell and on multi-cell selection.
Tested on the following versions:
Known issues with pull request:
Change log entries:
New features
The result of usual formatting shortcuts on Excel cells will now be reported.Code Review Checklist: