User guide: clarify the usage of character level in the Punctuation/symbol pronunciation dialog#14737
Conversation
…ymbol pronunciation dialog
|
I'm not quite sure how one is supposed to comment on this sort of change, and I do believe it's needed. I believe that @CyrilleB79 has suggested the following as the text to use in the documentation: I would propose this alternative:
|
|
Hello, I have the following comments:
|
|
+1 to @britechguy's proposed amendment.
|
|
Yes, I think that is the most succinct and clear way to do this. I will have
to play with it a bit though, as by definition, it still might be that the
odd punctuation is good in say all.
Brian
…--
***@***.***
Sent via blueyonder.(Virgin media)
Please address personal E-mail to:-
***@***.***, putting 'Brian Gaff'
in the display name field.
----- Original Message -----
From: "Brian Vogel" ***@***.***>
To: "nvaccess/nvda" ***@***.***>
Cc: "Subscribed" ***@***.***>
Sent: Thursday, March 23, 2023 11:43 PM
Subject: Re: [nvaccess/nvda] User guide: clarify the usage of character
level in the Punctuation/symbol pronunciation dialog (PR #14737)
I'm not quite sure how one is supposed to comment on this sort of change,
and I do believe it's needed. I believe that @CyrilleB79 has suggested
the following as the text to use in the documentation:
If you set the level on "character", the symbol will not be spoken
regardless of the symbol level you are using, except when you navigate by
character or when some text is spelt.
I would propose this alternative:
If the level is set to character, the symbol will not be spoken regardless
of the symbol level in use, with the following two exceptions:
1. When navigating character by character.
2. When NVDA is spelling any text containing that symbol.
--
Reply to this email directly or view it on GitHub:
#14737 (comment)
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
|
Thanks for the feedback. I have rephrased the paragraph according to @britechguy and @LittleStar-VIP's comments. Note: @britechguy, maybe you are not used to reviewing PRs. Going in the tab labeled "Files changed" you will see how the file has been modified in this PR. The modified lines in the file start with + or - indicating if they have been added or removed. Let us know if it's clear for you. And I hope you do not mind this note if you already knew all this. |
See test results for failed build of commit f6dd135470 |
22890ed to
8e46536
Compare
See test results for failed build of commit 44eb6f19ff |
Qchristensen
left a comment
There was a problem hiding this comment.
Looks good and should ease confusion around the setting, thanks!
Link to issue number:
Reported on NVDA mailing list in this thread.
Summary of the issue:
People are
In Punctuation/symbol pronunciation dialogue, in the level field, there is an options named "character". People are wondering what this option does since it is not documented in the user guide.
Description of user facing changes
Added a sentence in the doc to describe it.
Description of development approach
N/A
Testing strategy:
Known issues with pull request:
None
Change log entries:
Doc only; not needed.
Code Review Checklist: