Settings Ring: Lazily load available setting values the first time they're needed#14704
Merged
Merged
Conversation
michaelDCurran
approved these changes
Mar 20, 2023
LeonarddeR
added a commit
to LeonarddeR/nvda
that referenced
this pull request
Mar 25, 2023
… time they're needed (nvaccess#14704)" This reverts commit 1a47427.
This was referenced Mar 25, 2023
Closed
michaelDCurran
pushed a commit
that referenced
this pull request
Mar 27, 2023
In #14704, we introduced lazy loading of some settings ring settings. However, this resulted in error sounds being played when moving in the list of OneCore voices. Description of user facing changes Fix of the regression. Description of development approach The max value of a synth setting is based on the number of available settings. This is now dynamically fetched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
A settings ring entry for a String setting caches its possible values when creating the StringSynthSetting object. This can be costly if it takes some time for the possible values to return, for example when they're coming from a remote system in my remote desktop add-on.
Description of user facing changes
None.
Description of development approach
Load and cache the available settings values the first time they're fetched. This shouldn't have any noticeable impact for most synths.that
Testing strategy:
Tested with NVDA Remote Desktop add-on that initial setup of the remote synth is quicker, whereas the first selection of a settings ring entry is somewhat slower.
Known issues with pull request:
None
Change log entries:
For Developers
Code Review Checklist: