Skip to content

Old scripts remained in gestures.ini will not prevent anymore new gestures to be displayed in the INput gesture dialog#14600

Merged
michaelDCurran merged 1 commit into
nvaccess:masterfrom
CyrilleB79:inputGestureTree
Jan 30, 2023
Merged

Old scripts remained in gestures.ini will not prevent anymore new gestures to be displayed in the INput gesture dialog#14600
michaelDCurran merged 1 commit into
nvaccess:masterfrom
CyrilleB79:inputGestureTree

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #14599

Summary of the issue:

In some case (e.g. NVDA dev or add-on dev/update/uninstall), the file gesture.ini may contain script association for scripts that do not exist anymore in the current config. As described in #14599, if you try to reassign the shortcut that was used for such old removed scripts, the gesture may not be displayed in the input gesture dialog.

Description of user facing changes

When the file gesture.ini contains script association for unexisting scripts, e.g. due to old add-on or old devs in NVDA source code, there will not be anymore the risk that a gesture associated to a currently valid script be not displayed.

Description of development approach

  • If a script name is not found in a class, do not consider this script handled and remove it from the handledScripts set; also log a debugWarning in this case.
  • And also checked other continue statement (and commented one of them) to check the logic with respect to scripts added in this list.

Testing strategy:

Manual tests:
Checked with the steps of #14599 that we get the expected result, i.e. the gesture in the input gesture dialog.

Known issues with pull request:

None

Change log entries:

I do not know if this very specific issue deserve a change log entry. Maybe yes if someone has already encountered this situation and wondered why the gesture was not displayed in the input gesture dialog. I have tried the following phrasing, but an improvement is welcome!

Bug fixes
Gesture association to removed scripts will not cause anymore displaying issue when reusing the same gesture for another script. (#14599)

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

…tures to be displayed in the INput gesture dialog
@CyrilleB79 CyrilleB79 marked this pull request as ready for review January 30, 2023 22:02
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner January 30, 2023 22:02
@michaelDCurran michaelDCurran merged commit 080774d into nvaccess:master Jan 30, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Jan 30, 2023
@CyrilleB79 CyrilleB79 deleted the inputGestureTree branch February 2, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some gestures are not displayed in input gesture dialog

3 participants