Old scripts remained in gestures.ini will not prevent anymore new gestures to be displayed in the INput gesture dialog#14600
Merged
Conversation
…tures to be displayed in the INput gesture dialog
michaelDCurran
approved these changes
Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #14599
Summary of the issue:
In some case (e.g. NVDA dev or add-on dev/update/uninstall), the file
gesture.inimay contain script association for scripts that do not exist anymore in the current config. As described in #14599, if you try to reassign the shortcut that was used for such old removed scripts, the gesture may not be displayed in the input gesture dialog.Description of user facing changes
When the file
gesture.inicontains script association for unexisting scripts, e.g. due to old add-on or old devs in NVDA source code, there will not be anymore the risk that a gesture associated to a currently valid script be not displayed.Description of development approach
continuestatement (and commented one of them) to check the logic with respect to scripts added in this list.Testing strategy:
Manual tests:
Checked with the steps of #14599 that we get the expected result, i.e. the gesture in the input gesture dialog.
Known issues with pull request:
None
Change log entries:
I do not know if this very specific issue deserve a change log entry. Maybe yes if someone has already encountered this situation and wondered why the gesture was not displayed in the input gesture dialog. I have tried the following phrasing, but an improvement is welcome!
Bug fixes
Gesture association to removed scripts will not cause anymore displaying issue when reusing the same gesture for another script. (#14599)Code Review Checklist: