…ond to last item (#14574)"

This reverts commit 2c33c27.

…ond to last item (#14574)" (#14620)

This reverts commit 2c33c27.

…etching status bar. Re nvaccess#14573.

nvaccess#14574 rework: Notepad 11.2301 introduces tabbed Notepad where multiple documents can be opened at once. This changes the Notepad UI tree so the old status bar chlid index no longer works. In the now reverted nvaccess#14574 pull request, a different status bar index was used, but it had a critical flaw: when Notepad settings (Alt+S) opens and then closes, status bar command will say something, caused by UI tree changing once again. A more robust solution is using UIA descendants to look for a specific element, and provided that the Automation Id for the first status bar text stays the same (ContentTextBlock), the descendants approach will work. This is the same approach used in File Explorer app module to obtain status bar contents in File Explorer.

… app releases via UIA decendants (#14622)

Closes #14573
Take 2 on #14573
Resolves a flaw discovered in #14574

Summary of the issue:
In #14574 and earlier, NVDA relied on child index when retrieving Windows 11 Notepad status bar contents. This is flawed: there are times when UI tree in Notepad can change if something opens and then closes. Specifically, when Notepad settings window (Alt+S) is opened and then closed, NVDA will announce something else when retrieving status bar contents.

Description of user facing changes
NVDA will announce status bar contents in newer Windows 11 Notepad releases (same as #14574).

Description of development approach
Use UIA's FindFirstBuildCache to retrieve status bar contents (Automation Id: ContentTextBlock). As long as the Automation Id stays the same, the descendants approach will work across Notepad 11 releases.

---
commits:

* appModules/notepad: use UIA descendants instead of child index when fetching status bar. Re #14573.

#14574 rework: Notepad 11.2301 introduces tabbed Notepad where multiple documents can be opened at once. This changes the Notepad UI tree so the old status bar chlid index no longer works. In the now reverted #14574 pull request, a different status bar index was used, but it had a critical flaw: when Notepad settings (Alt+S) opens and then closes, status bar command will say something, caused by UI tree changing once again. A more robust solution is using UIA descendants to look for a specific element, and provided that the Automation Id for the first status bar text stays the same (ContentTextBlock), the descendants approach will work. This is the same approach used in File Explorer app module to obtain status bar contents in File Explorer.

* appModules/notepad: restore copyright header and type hints. Re #14573

* appModules/notepad: uiItemWindow -> notepadWindow

* appModules/notepad: status bar/UIA descendatns now resembles File Explorer app module more closely. Re #14573.

Inspired by status bar getter in File Explorer app module: because Notepad foreground window is not a UIA element, tell UIA handler to obtain UIA element from foreground window handle. Apart from this and checking for AutomationId, Notepad status bar getter resembles File Explorer app module.

* appModules/notepad: catch value error if the status bar content UIA element is NULL.

UIA element for status bar contents wil be NULL (0x0) if status bar is not showing, therefore catch value error that can result from it.

* appModules/notepad: remove status bar location check.

Since status bar UIA element is not defined if invisible, there is no need to check its location.

* appModules/notepad: UIAHandler.handler.clientObject -> clientObject

* update changes

---------

Co-authored-by: Sean Budd <sean@nvaccess.org>