Skip to content

Braille: report 'details' for non-landmarks#14425

Merged
feerrenrut merged 4 commits into
masterfrom
brailleDetailsForNonLandmarks-13815
Dec 12, 2022
Merged

Braille: report 'details' for non-landmarks#14425
feerrenrut merged 4 commits into
masterfrom
brailleDetailsForNonLandmarks-13815

Conversation

@feerrenrut

@feerrenrut feerrenrut commented Dec 7, 2022

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #13815

Summary of the issue:

"details" not reported with braille for some elements.
Test case: https://codepen.io/reefturner/pen/VwdgxPv

Description of user facing changes

Braille will now report "details" for non-landmark elements.

Description of development approach

Found missing case, get braille for text properties and add to output.

Testing strategy:

Manually tested case: https://codepen.io/reefturner/pen/VwdgxPv

Known issues with pull request:

None

Change log entries:

Bug fixes

- The presence of an annotation is no longer missing in braille for some elements.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@feerrenrut feerrenrut added component/braille component/braille-ux User experience for braille labels Dec 7, 2022
@feerrenrut feerrenrut mentioned this pull request Dec 7, 2022
8 tasks
@AppVeyorBot

This comment was marked as outdated.

Braille output has changed
@feerrenrut feerrenrut marked this pull request as ready for review December 8, 2022 09:16
@feerrenrut feerrenrut requested a review from a team as a code owner December 8, 2022 09:16
@feerrenrut feerrenrut changed the title Braille: report 'has details' for non-landmarks Braille: report 'details' for non-landmarks Dec 9, 2022
@feerrenrut feerrenrut merged commit dc6ae59 into master Dec 12, 2022
@feerrenrut feerrenrut deleted the brailleDetailsForNonLandmarks-13815 branch December 12, 2022 09:08
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report "has details" in braille for non-landmark content

4 participants