Prototype Nav to annotation and return in browse mode#14389
Closed
feerrenrut wants to merge 5 commits into
Closed
Conversation
0b5c749 to
d096ffc
Compare
3fe1efd to
ba0da60
Compare
8 tasks
7 tasks
seanbudd
added a commit
that referenced
this pull request
Jan 5, 2023
Supersedes #14389 and #14426. Fixes #14360 Summary of the issue: Before this PR, NVDA was only aware of the first annotation target. NVDA announces the presence of an annotation target. nvda+d is used to announce the summary of the first annotation target. This PR introduces base code to support multiple annotation targets, and enables cycling though reporting each summary. Similarly, #14507 introduces reporting the presence of multiple annotation targets. Description of user facing changes nvda+d now cycles through reporting each annotation target for an annotated item. For example reading the summary of each child comment. Description of development approach Creates abstractions for the relationships between annotation origins and targets. The global command to report a summary of an annotation target has been updated.
Collaborator
|
I'll use the code provided on this PR for the next version of the enhancedAnnotations add-on., just with minor changes. |
Member
|
Closing this as abandoned. The prototype has been implemented in an add-on. We can consider the implementation and UX there in a future re-attempt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this is just a prototype. There are several more aspect of the UX that need to be developed and combined to test the full experience. Once the prototypes are accepted, then the work can be polished and made ready for alpha.
Link to issue number:
Partial fix for #13940
Summary of the issue:
When encountering an annotation, "has details" is reported.
The summary of the annotation can be reported with
NVDA+dHowever, if the annotation contains complex structure, or can be interacted with (E.G. a comment thread), there is no easy way for the user to navigate to the annotation.
Additionally, some locations may have multiple annotation targets.
Description of user facing changes
Please note, the shortcuts used are not final, and not intended to be the focus of this prototype.
Overview:
NVDA+dto select the annotation they are interested in (based on the reported summary).NVDA+alt+dwill navigate to the annotation target last summarized. After navigation, NVDA will 'read line' for the location.NVDA+alt+shift+dwill navigate back to the annotation origin.Description of development approach
globalCommands.pyTesting strategy:
Known issues with pull request:
Max 10 targets are fetched, this should be dynamic, however there is a bug preventing this, requiring investigation.
Change log entries:
New features
Changes
Bug fixes
For Developers
Code Review Checklist: