Report name of configuration profile when deleting#14245
Merged
Conversation
seanbudd
reviewed
Oct 14, 2022
seanbudd
approved these changes
Oct 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #13677
Summary of the issue:
When deleting a profile, the confirmation dialog does not name the profile that should be deleted
Description of user facing changes
The name of the profile is added to the message box text, also, like the addons deletion dialog, cancel is the default to prevent accidental deletion.
Description of development approach
Change message box text to
Testing strategy:
Deleted a profile, insured that the profile name is spoken
Known issues with pull request:
None
Change log entries:
New features
Changes
Bug fixes
For Developers
Code Review Checklist: