Skip to content

Merge beta to master#14227

Merged
seanbudd merged 18 commits into
masterfrom
mergeBetatoMaster
Oct 10, 2022
Merged

Merge beta to master#14227
seanbudd merged 18 commits into
masterfrom
mergeBetatoMaster

Conversation

@seanbudd

Copy link
Copy Markdown
Member

Must be merge commit not squash merge

NVDA translation automation and others added 18 commits October 7, 2022 00:01
From translation svn revision: 70091

Authors:
Bernd Dorer <bdorer@mailbox.org>
David Parduhn <xkill85@gmx.net>
Rene Linke <rene.linke@hamburg.de>
Adriani Botez <adriani.botez@gmail.com>
Karl Eick <hozosch@web.de>
Robert Hänggi <aarjay.robert@gmail.com>
Astrid Waldschmetterling <a.r.waldschmetterling@gmx.de>

Stats:
40	32	user_docs/de/changes.t2t
 1 file changed, 40 insertions(+), 32 deletions(-)
From translation svn revision: 70091

Authors:
Juan C. buno <oprisniki@gmail.com>
Noelia Martinez <nrm1977@gmail.com>
Remy Ruiz <remyruiz@gmail.com>
Jose M. Delicado <jm.delicado@nvda.es>

Stats:
8	0	user_docs/es/changes.t2t
 1 file changed, 8 insertions(+)
From translation svn revision: 70091

Authors:
Ali Aslani <aslani.ali@gmail.com>
Mohammadreza Rashad <mohammadreza5712@gmail.com>

Stats:
8	0	user_docs/fa/changes.t2t
 1 file changed, 8 insertions(+)
From translation svn revision: 70091

Authors:
Jani Kinnunen <janikinnunen340@gmail.com>
Isak Sand <isak.sand@gmail.com>

Stats:
8	0	user_docs/fi/changes.t2t
 1 file changed, 8 insertions(+)
From translation svn revision: 70091

Authors:
Michel such <michel.such@free.fr>
Patrick ZAJDA <patrick@zajda.fr>
Remy Ruiz <remyruiz@gmail.com>
Abdelkrim Bensaid <abdelkrim.bensaid@free.fr>
Cyrille Bougot <cyrille.bougot2@laposte.net>
Corentin Bacqué-Cazenave <corentin@progaccess.net>
Sylvie Duchateau <sylvieduchateau@gmail.com>
Sof <hellosof@gmail.com>

Stats:
8	0	user_docs/fr/changes.t2t
 1 file changed, 8 insertions(+)
From translation svn revision: 70091

Authors:
Juan C. buno <oprisniki@gmail.com>
Ivan Novegil <ivan.novegil@nvda.es>
Javier Curras <javier.curras@nvda.es>
Jose M. Delicado <jm.delicado@nvda.es>

Stats:
8	0	user_docs/gl/changes.t2t
 1 file changed, 8 insertions(+)
From translation svn revision: 70091

Authors:
Beqa Gozalishvili <beqaprogger@gmail.com>
Goderdzi Gogoladze <goderdzigogoladze@gmail.com>

Stats:
21	47	source/locale/ka/LC_MESSAGES/nvda.po
 1 file changed, 21 insertions(+), 47 deletions(-)
From translation svn revision: 70091

Authors:
Cagri Dogan <cagrid@hotmail.com>

Stats:
408	407	source/locale/tr/LC_MESSAGES/nvda.po
 1 file changed, 408 insertions(+), 407 deletions(-)
From translation svn revision: 70091

Authors:
vgjh2005@gmail.com
jiangtiandao901647@gmail.com
manchen_0528@outlook.com
dingpengyu06@gmail.com
singer.mike.zhao@gmail.com
1872265132@qq.com

Stats:
8	0	user_docs/zh_CN/changes.t2t
 1 file changed, 8 insertions(+)
From translation svn revision: 70091
…y left out of pr #14165 (#14223)

Summary of the issue:
PR #14165 was to make it so that when moving outside of a table in Excel, NVDA would announce exiting the table.
However, part of the code was accidentally left out of the pr, namely the code to choose the ExcelTable class for Excel table elements.

Description of user facing changes
NVDA will now really report exiting tables in Microsoft Excel.

Description of development approach
UIA NVDAObject's findOverlayClasses includes the ExcelTable NVDAObject class for Excel tables.

Testing strategy:
Performed steps for pr #14165.
Fixes #14214
See also #14213

Summary of the issue:
The current battery status message when pressing NVDA+shift+b is too verbose, because it reports the AC status before the battery level.

This is useful for an AC state change (e.g. when plugging in a charger)
But is not ideal for when pressing NVDA+shift+b to fetch the battery status.

Description of user facing changes
Reverts to previous ordering in 2022.3.

When the AC status changes, the AC status is still reported first: "charging" or "AC disconnected".
When NVDA+shift+b is pressed to fetch the battery status, the battery status is reported first: "X percentage, Z hours and Y minutes remaining"

Description of development approach
Change internal parameter onlyReportIfStatusChanged to _ReportContext.
A _ReportContext is used to determine order of speech.

When the context is an AC status change, this reports the current AC status first.
When the context is a user fetching the current battery status, this reports the remaining battery life first.
@seanbudd seanbudd requested a review from a team as a code owner October 10, 2022 05:10
@seanbudd seanbudd requested a review from feerrenrut October 10, 2022 05:10
@seanbudd seanbudd merged commit 139e291 into master Oct 10, 2022
@seanbudd seanbudd deleted the mergeBetatoMaster branch October 10, 2022 07:15
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants