Skip to content

UIA: actually use ExcelTable NVDAObject for Excel tables. Accidentally left out of pr #14165#14223

Merged
seanbudd merged 2 commits into
branchFor2022.4from
pr14165_fix
Oct 10, 2022
Merged

UIA: actually use ExcelTable NVDAObject for Excel tables. Accidentally left out of pr #14165#14223
seanbudd merged 2 commits into
branchFor2022.4from
pr14165_fix

Conversation

@michaelDCurran

@michaelDCurran michaelDCurran commented Oct 9, 2022 •
edited by seanbudd
Loading

Copy link
Copy Markdown
Member

Link to issue number:

None.

Summary of the issue:

PR #14165 was to make it so that when moving outside of a table in Excel, NVDA would announce exiting the table.
However, part of the code was accidentally left out of the pr, namely the code to choose the ExcelTable class for Excel table elements.

Description of user facing changes

NVDA will now really report exiting tables in Microsoft Excel.

Description of development approach

UIA NVDAObject's findOverlayClasses includes the ExcelTable NVDAObject class for Excel tables.

Testing strategy:

Performed steps for pr #14165.

Known issues with pull request:

None.

Change log entries:

New features
Changes
Bug fixes
For Developers

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@michaelDCurran michaelDCurran requested a review from a team as a code owner October 9, 2022 00:29
@michaelDCurran michaelDCurran added this to the 2022.4 milestone Oct 9, 2022
@seanbudd seanbudd changed the base branch from master to branchFor2022.4 October 9, 2022 23:26
@seanbudd seanbudd changed the base branch from branchFor2022.4 to master October 9, 2022 23:26
@seanbudd

seanbudd commented Oct 9, 2022

Copy link
Copy Markdown
Member

Could this be re-based on and re-targeted to branchFor2022.4?

@seanbudd seanbudd added the release/blocking this issue blocks the milestone release label Oct 10, 2022
@michaelDCurran michaelDCurran changed the base branch from master to branchFor2022.4 October 10, 2022 01:23
@michaelDCurran

michaelDCurran commented Oct 10, 2022

Copy link
Copy Markdown
Member Author

I've rebased and retargetted to branchFor2022.4.

@seanbudd seanbudd merged commit 1e25c84 into branchFor2022.4 Oct 10, 2022
@seanbudd seanbudd deleted the pr14165_fix branch October 10, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees

No one assigned

Labels

release/blocking this issue blocks the milestone release

Projects

None yet

Milestone

2022.4

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelDCurran @seanbudd