Conversation
4d9e547 to
5551883
Compare
See test results for failed build of commit d3db45f4f3 |
Member
Author
|
This try build is available for testing |
8 tasks
Member
Author
|
Closing in favour of #14105, as changing the desktop object is too risky for a point release. |
seanbudd
added a commit
that referenced
this pull request
Sep 6, 2022
Supersedes #14098 Fixes #14094 Summary of the issue: SecureDesktopNVDAObject needs to be whitelisted on the lock screen. This is an NVDAObject used to notify the user and API consumers that NVDA has entered a secure desktop. Description of user facing changes Fixes NVDA remote bug described in #14094. "Secure Desktop" is now consistently announced again when entering a secure desktop. Description of development approach Add SecureDesktopNVDAObject to the whitelist of available objects on the lock screen. Ensures that when setting the foreground event does not occur via doPreGainFocus for SecureDesktopNVDAObject. This is because the foreground event cannot be handled in a secure manner, and is not required for the SecureDesktopNVDAObject API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #14094
Summary of the issue:
SecureDesktopNVDAObjectneeds to be whitelisted on the lock screen.This is an NVDA Object used to notify the user and API consumers that NVDA has entered a secure desktop.
In a separate issue, we should investigate if other approaches should be recommended for API consumers (eg session tracking, secure mode check).
Description of user facing changes
Fixes NVDA remote bug described in #14094.
"Secure Desktop" is now consistently announced again when entering a secure desktop.
Description of development approach
Add
SecureDesktopNVDAObjectto the whitelist of available objects on the lock screen.Changes the desktop to
SecureDesktopNVDAObjectwhen the desktop switches.Ensures that when setting the foreground object via
doPreGainFocusthat the focused object is above the lockscreen.An alternative (and possibly safer) development approach.
To avoid setting the desktop object, an alternative is to check the returned handle of
windll.user32.OpenInputDesktop(0, False, 0)and whitelistDesktopobjects as if they wereSecureDesktopNVDAObjectif the returned handle is a secure desktop.Testing strategy:
Manual testing
Known issues with pull request:
None
Change log entries:
Refer to PR diff
Code Review Checklist: