NVDAObjects.UIA: introduce UIA is grabbed property handler#14097
Merged
Conversation
…s#14081. When elements are about to be dragged, UIA sets 'IsGrabed' property to True. Add this property to UIA object states set so it can be detected and announced by NVDA (announcement is next commit).
… Re nvaccess#14081. Treat 'is grabbed' property chnages as state changes. This will result in NVDA saying 'dragging' when items are grabbed, most notably when rearranging tiles in Windows 10 start menu.
seanbudd
approved these changes
Sep 2, 2022
See test results for failed build of commit 7a8a4c4836 |
6 tasks
See test results for failed build of commit 7a8a4c4836 |
6 tasks
seanbudd
pushed a commit
that referenced
this pull request
Sep 5, 2022
…nge events. Re #14081. (#14104) Additional fix for #14081 Follow-up to #14097 Summary of the issue: NVDA is not announcing "dragging' when the item being dragged is let go and dragged again. Description of user facing changes When the item is grabbed a second tie, NVDA will announce 'dragging'. Description of development approach Add and map UIA drag cancel and complete events to state changes. This allows UIA object states cache to reflect the fact that "is grabbed" property is False, allowing NVDA to announce "dragging" when the item is grabbed again. At the moment NVDA will not say "done dragging" when drag complete event fires - that might be something to investigate in the future (remapping drag cancel/commplete events or doing soething with state change event/speech output). Without defining UIA drag cancel and complete events, NVDA will not nanounce 'dragging' when dragging the selected item a second time (the added events do allow flushing staes cache as part of state change event, although NVDA will not nanounce 'done dragging' which is somethig to be investigated in the future).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
First part of two-part pull request series to handle keyboard-based accessible drag and drop powered by UI Automation, ultimately deriving from #12271 work:
Link to issue number:
Closes #14081
Summary of the issue:
NVDA does not recognize if a UIA element is about to be dragged when using keyboards.
Description of user facing changes
When a UIA element such as Windows 10 Start menu tile is about to be dragged and rearranged, NVDA will say "dragging" to indicate the dragging state.
Description of development approach
Add UIA "IsGrabbed" property to list of states to be handled by UIA objects, and map drag start UIA event to state change event.
Testing strategy:
Manual and add-on based testing:
Prerequisites: a Windows 10 system.
Before the PR: NVDA does not announce anything.
After the PR: NVDA says "dragging".
Known issues with pull request:
This does not address another drag and drop events set, namely drop target enter/leave/dropped events, nor announces drag drop effect (a separate property must be handled). A follow-up pull request, designed to address these known issues in one go, is on its way. A resolution to the issues described is part of latest development builds of Windows App Essentials add-on.
Change log entries:
Bug fixes (or can go under new features):
NVDA will announce dragging state when a UI Automation control is about to be dragged via mouse or keyboard, notably when rearranging tiles in Windows 10 start menu. (#14081)
Code Review Checklist: