UI Automation in Windows Console: expose all three config options in preparation for usage by default#13807
Merged
Conversation
It was requested in nvaccess#10964 (comment) that the ternary option be exposed separately to the change in default behaviour to ease revertability. This commit exposes the ternary option as requested and updates the user guide in preparation for PR nvaccess#10964. Co-authored-by: Łukasz Golonka <lukasz.golonka@mailbox.org>
50e3fd5 to
256cdb3
Compare
See test results for failed build of commit 05958c44f6 |
See test results for failed build of commit 16e1eb8a64 |
seanbudd
approved these changes
Jun 20, 2022
seanbudd
left a comment
Member
There was a problem hiding this comment.
Thanks @codeofdusk - code changes look good. I've reformatted the userGuide changes slightly.
Contributor
Author
|
@seanbudd I can't see your user guide changes. Have they been committed yet? |
seanbudd
reviewed
Jun 20, 2022
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
See test results for failed build of commit a4a3e4631c |
seanbudd
approved these changes
Jun 21, 2022
Qchristensen
approved these changes
Jun 21, 2022
Qchristensen
left a comment
Member
There was a problem hiding this comment.
User guide changes read well, good work!
codeofdusk
added a commit
to codeofdusk/nvda
that referenced
this pull request
Jun 21, 2022
Follow-up of nvaccess#13807. Co-authored-by: Łukasz Golonka <lukasz.golonka@mailbox.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Blocking #10964.
Summary of the issue:
It was requested in #10964 (comment) that the ternary option be exposed separately to the change in default behaviour to ease revertability.
Description of how this pull request fixes the issue:
Exposes the ternary option as requested and updates the user guide.
Testing strategy:
Tested that all three values of the combo box update the config as expected (including that "automatic" uses the legacy support).
Known issues with pull request:
None known.
Change log entries:
None needed (update changelog as part of #10964).
Code Review Checklist: