No longer rely on star imports in NVDAObjects.IAccessible.winword#13805
Merged
seanbudd merged 2 commits intoJun 17, 2022
Conversation
15 tasks
See test results for failed build of commit 3cc40dc63b |
See test results for failed build of commit a02ee61077 |
c9d4151 to
4d51453
Compare
See test results for failed build of commit 7a033223fc |
5 tasks
seanbudd
pushed a commit
that referenced
this pull request
Jun 18, 2022
…S Outlook (#13811) Fixes #13810 Summary of the issue: PR #13805 removed star imports from NVDAObjects.IAccessible.winword. Unfortunately the appModule for MS Outlook relied on some of the stuff star imported there. Description of user facing changes MS Outlook can once again be used with Alpha versions of NVDA. Description of development approach Inspected all imports from NVDAObjects.IAccessible.winword - - where they imported stuff which is actually defined in NVDAObjects.window.winword the imports were made explicit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None, found when testing code from PR #13575
Summary of the issue:
NVDAObjects.IAccessible.winwordstar imports everything fromNVDAObjects.window.winword. This may cause issues when removing imports fromNVDAObjects.window.winword, it is also better to be explicit.Description of how this pull request fixes the issue:
NVDAObjects.IAccessible.winwordnow imports all used modules explicitly.Testing strategy:
NVDAObjects.IAccessible.winwordmodule - made sure no undefined names show upKnown issues with pull request:
None known
Change log entries:
None needed
Code Review Checklist: